Re: [PATCH v3 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

2019-07-24 Thread Vaibhav Rustagi
On Tue, Jul 23, 2019 at 2:24 PM Nick Desaulniers wrote: > > KBUILD_CFLAGS is very carefully built up in the top level Makefile, > particularly when cross compiling or using different build tools. > Resetting KBUILD_CFLAGS via := assignment is an antipattern. > > The comment above the reset

Re: [PATCH v3 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

2019-07-24 Thread Thomas Gleixner
On Tue, 23 Jul 2019, Nick Desaulniers wrote: > +ifdef CONFIG_FUNCTION_TRACER > +CFLAGS_REMOVE_sha256.o += $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_purgatory.o += $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_string.o += $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_kexec-purgatory.o += $(CC_FLAGS_FTRACE) Nit. Can you

[PATCH v3 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

2019-07-23 Thread Nick Desaulniers
KBUILD_CFLAGS is very carefully built up in the top level Makefile, particularly when cross compiling or using different build tools. Resetting KBUILD_CFLAGS via := assignment is an antipattern. The comment above the reset mentions that -pg is problematic. Other Makefiles use