Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-10 Thread Lina Iyer
On Thu, Jul 09 2015 at 02:33 -0600, Jisheng Zhang wrote: As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver get 'cpu' itself if need. As for the init member function, the device_node here may not

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-10 Thread Lina Iyer
On Thu, Jul 09 2015 at 03:28 -0600, Lorenzo Pieralisi wrote: On Thu, Jul 09, 2015 at 09:43:04AM +0100, Jisheng Zhang wrote: On Thu, 9 Jul 2015 16:31:24 +0800 Jisheng Zhang wrote: > As for the suspend member function, the to-be-suspended cpu is always > the calling cpu itself, so the 'cpu'

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-10 Thread Lina Iyer
On Thu, Jul 09 2015 at 03:28 -0600, Lorenzo Pieralisi wrote: On Thu, Jul 09, 2015 at 09:43:04AM +0100, Jisheng Zhang wrote: On Thu, 9 Jul 2015 16:31:24 +0800 Jisheng Zhang jszh...@marvell.com wrote: As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself,

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-10 Thread Lina Iyer
On Thu, Jul 09 2015 at 02:33 -0600, Jisheng Zhang wrote: As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver get 'cpu' itself if need. As for the init member function, the device_node here may not

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 09, 2015 at 09:43:04AM +0100, Jisheng Zhang wrote: > On Thu, 9 Jul 2015 16:31:24 +0800 > Jisheng Zhang wrote: > > > As for the suspend member function, the to-be-suspended cpu is always > > the calling cpu itself, so the 'cpu' parameter may not be necessary, let > > driver get 'cpu'

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Jisheng Zhang
On Thu, 9 Jul 2015 16:31:24 +0800 Jisheng Zhang wrote: > As for the suspend member function, the to-be-suspended cpu is always > the calling cpu itself, so the 'cpu' parameter may not be necessary, let > driver get 'cpu' itself if need. > > As for the init member function, the device_node here

[PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Jisheng Zhang
As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver get 'cpu' itself if need. As for the init member function, the device_node here may not be necessary either, because we can get the node via.

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Jisheng Zhang
On Thu, 9 Jul 2015 16:31:24 +0800 Jisheng Zhang jszh...@marvell.com wrote: As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver get 'cpu' itself if need. As for the init member function, the

[PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Jisheng Zhang
As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver get 'cpu' itself if need. As for the init member function, the device_node here may not be necessary either, because we can get the node via.

Re: [PATCH v3 2/3] ARM: cpuidle: refine cpuidle_ops member's parameters.

2015-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 09, 2015 at 09:43:04AM +0100, Jisheng Zhang wrote: On Thu, 9 Jul 2015 16:31:24 +0800 Jisheng Zhang jszh...@marvell.com wrote: As for the suspend member function, the to-be-suspended cpu is always the calling cpu itself, so the 'cpu' parameter may not be necessary, let driver