Re: [PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization

2018-09-13 Thread Mark Brown
On Wed, Sep 12, 2018 at 01:44:41PM -0600, Yu Zhao wrote: > In snd_hdac_bus_init_chip(), we enable interrupt before > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has > been acquired and irq handler uses the dma buffer, kernel may crash > when interrupt comes in. > --- >

Re: [PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization

2018-09-13 Thread Mark Brown
On Wed, Sep 12, 2018 at 01:44:41PM -0600, Yu Zhao wrote: > In snd_hdac_bus_init_chip(), we enable interrupt before > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has > been acquired and irq handler uses the dma buffer, kernel may crash > when interrupt comes in. > --- >

[PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization

2018-09-12 Thread Yu Zhao
In snd_hdac_bus_init_chip(), we enable interrupt before snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has been acquired and irq handler uses the dma buffer, kernel may crash when interrupt comes in. Fix the problem by postponing enabling irq after dma buffer initialization. And warn

[PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization

2018-09-12 Thread Yu Zhao
In snd_hdac_bus_init_chip(), we enable interrupt before snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has been acquired and irq handler uses the dma buffer, kernel may crash when interrupt comes in. Fix the problem by postponing enabling irq after dma buffer initialization. And warn