Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-12 Thread Markus Mayer
On 11 October 2016 at 22:38, Viresh Kumar wrote: > On 07-10-16, 16:21, Markus Mayer wrote: >> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) >> +{ >> + struct private_data *priv = policy->driver_data; >> + >> + iounmap(priv->base); >> +

Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-12 Thread Markus Mayer
On 11 October 2016 at 22:38, Viresh Kumar wrote: > On 07-10-16, 16:21, Markus Mayer wrote: >> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) >> +{ >> + struct private_data *priv = policy->driver_data; >> + >> + iounmap(priv->base); >> + iounmap(priv->avs_intr_base);

Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-11 Thread Viresh Kumar
On 07-10-16, 16:21, Markus Mayer wrote: > +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) > +{ > + struct private_data *priv = policy->driver_data; > + > + iounmap(priv->base); > + iounmap(priv->avs_intr_base); > + > + return 0; > +} Shouldn't the above be done in

Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-11 Thread Viresh Kumar
On 07-10-16, 16:21, Markus Mayer wrote: > +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) > +{ > + struct private_data *priv = policy->driver_data; > + > + iounmap(priv->base); > + iounmap(priv->avs_intr_base); > + > + return 0; > +} Shouldn't the above be done in

[PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-07 Thread Markus Mayer
This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and

[PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

2016-10-07 Thread Markus Mayer
This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and