Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-08 Thread Tomeu Vizoso
On 6 August 2016 at 19:04, Daniel Stone wrote: > Hi Tomeu, > > On 22 July 2016 at 15:10, Tomeu Vizoso wrote: >> +/** >> + * DOC: CRC ABI >> + * >> + * DRM device drivers can provide to userspace CRC information of each >> frame as >> + * it

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-08 Thread Tomeu Vizoso
On 6 August 2016 at 19:04, Daniel Stone wrote: > Hi Tomeu, > > On 22 July 2016 at 15:10, Tomeu Vizoso wrote: >> +/** >> + * DOC: CRC ABI >> + * >> + * DRM device drivers can provide to userspace CRC information of each >> frame as >> + * it reached a given hardware component (a "source"). >> +

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-06 Thread Daniel Stone
Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame > as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-06 Thread Daniel Stone
Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame > as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-05 Thread Ville Syrjälä
On Fri, Aug 05, 2016 at 12:46:29PM +0200, Tomeu Vizoso wrote: > On 3 August 2016 at 09:06, Ville Syrjälä > wrote: > > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > >> Adds files and directories to debugfs for controlling and reading frame > >>

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-05 Thread Ville Syrjälä
On Fri, Aug 05, 2016 at 12:46:29PM +0200, Tomeu Vizoso wrote: > On 3 August 2016 at 09:06, Ville Syrjälä > wrote: > > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > >> Adds files and directories to debugfs for controlling and reading frame > >> CRCs, per CRTC: > >> > >>

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
On 3 August 2016 at 09:06, Ville Syrjälä wrote: > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: >> Adds files and directories to debugfs for controlling and reading frame >> CRCs, per CRTC: >> >> dri/0/crtc-0/crc >> dri/0/crtc-0/crc/control >>

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
On 3 August 2016 at 09:06, Ville Syrjälä wrote: > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: >> Adds files and directories to debugfs for controlling and reading frame >> CRCs, per CRTC: >> >> dri/0/crtc-0/crc >> dri/0/crtc-0/crc/control >> dri/0/crtc-0/crc/data >> >> Drivers

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-03 Thread Daniel Vetter
On Wed, Aug 03, 2016 at 10:06:38AM +0300, Ville Syrjälä wrote: > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > > Adds files and directories to debugfs for controlling and reading frame > > CRCs, per CRTC: > > > > dri/0/crtc-0/crc > > dri/0/crtc-0/crc/control > >

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-03 Thread Daniel Vetter
On Wed, Aug 03, 2016 at 10:06:38AM +0300, Ville Syrjälä wrote: > On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > > Adds files and directories to debugfs for controlling and reading frame > > CRCs, per CRTC: > > > > dri/0/crtc-0/crc > > dri/0/crtc-0/crc/control > >

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-03 Thread Ville Syrjälä
On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, per CRTC: > > dri/0/crtc-0/crc > dri/0/crtc-0/crc/control > dri/0/crtc-0/crc/data > > Drivers can implement the set_crc_source callback() in

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-03 Thread Ville Syrjälä
On Fri, Jul 22, 2016 at 04:10:44PM +0200, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, per CRTC: > > dri/0/crtc-0/crc > dri/0/crtc-0/crc/control > dri/0/crtc-0/crc/data > > Drivers can implement the set_crc_source callback() in

[PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-07-22 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output

[PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-07-22 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output