Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-11 Thread Wolfram Sang
On Mon, Sep 24, 2018 at 04:52:34PM -0700, Stephen Boyd wrote: > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-11 Thread Wolfram Sang
On Mon, Sep 24, 2018 at 04:52:34PM -0700, Stephen Boyd wrote: > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-04 Thread alokc
On 2018-09-25 05:22, Stephen Boyd wrote: We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-04 Thread alokc
On 2018-09-25 05:22, Stephen Boyd wrote: We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-09-25 Thread Doug Anderson
Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: > > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-09-25 Thread Doug Anderson
Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: > > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message

[PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-09-24 Thread Stephen Boyd
We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything fits in 80 columns and testing the 'dma_buf'

[PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-09-24 Thread Stephen Boyd
We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything fits in 80 columns and testing the 'dma_buf'