Re: [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq【请注意，邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】

[Kever Yang]

On 2020/10/13 下午2:37, Jianqun Xu wrote:

There need to enable pclk_gpio when do irq_create_mapping, since it will
do access to gpio controller.

Reviewed-by: Heiko Stuebner <he...@sntech.de>
Signed-off-by: Jianqun Xu <jay...@rock-chips.com>
---
  drivers/pinctrl/pinctrl-rockchip.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c 
b/drivers/pinctrl/pinctrl-rockchip.c
index 927d132d6716..a2f361aa6d05 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, 
unsigned offset)
        if (!bank->domain)
                return -ENXIO;

+ clk_enable(bank->clk);

        virq = irq_create_mapping(bank->domain, offset);
+       clk_disable(bank->clk);

return (virq) ? : -ENXIO;

  }

Looks good to me,

Reviewed-by: Kever Yang<kever.y...@rock-chips.com>

Thanks,
- Kever