Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-09 Thread Rajat Jain
On Mon, Apr 8, 2019 at 12:34 PM Andy Shevchenko wrote: > > On Mon, Apr 8, 2019 at 9:58 PM Rajat Jain wrote: > > On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko > > wrote: > > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > > > > Instead of adding module parameter and doing these prints, pe

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 8, 2019 at 9:58 PM Rajat Jain wrote: > On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko > wrote: > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > > Instead of adding module parameter and doing these prints, perhaps > > introduce another debugfs node. > > Uh, I actually did want

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko wrote: > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > > On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko > > wrote: > > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Perhaps something like > > > > > > pmcdev->check_counters =

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko > wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > Perhaps something like > > > > pmcdev->check_counters = false; > > /* User doesn't want to be warned */ > > if (!warn_on...) > >

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Add a module parameter which when enabled, will check on resume, if the > > last S0ix attempt was successful. If not, the driver would warn and provide > > helpful debug informatio

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > Add a module parameter which when enabled, will check on resume, if the > last S0ix attempt was successful. If not, the driver would warn and provide > helpful debug information (which gets latched during the failed suspend > attempt) to debug

[PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-05 Thread Rajat Jain
Add a module parameter which when enabled, will check on resume, if the last S0ix attempt was successful. If not, the driver would warn and provide helpful debug information (which gets latched during the failed suspend attempt) to debug the S0ix failure. This information is very useful to debug S