> -Original Message-
> From: Anton Vorontsov [mailto:anton.voront...@linaro.org]
> Sent: Thursday, August 23, 2012 2:54 PM
> To: Kim, Milo
> Cc: sa...@linux.intel.com; linux-kernel@vger.kernel.org; Jonathan
> Cameron
> Subject: Re: [PATCH v3 2/3] power_supply: a
-Original Message-
From: Anton Vorontsov [mailto:anton.voront...@linaro.org]
Sent: Thursday, August 23, 2012 2:54 PM
To: Kim, Milo
Cc: sa...@linux.intel.com; linux-kernel@vger.kernel.org; Jonathan
Cameron
Subject: Re: [PATCH v3 2/3] power_supply: add new lp8788 charger driver
On Tue, Aug 14, 2012 at 02:32:50AM +, Kim, Milo wrote:
> Patch v3.
Thanks for the driver! It looks great, mostly cosmetic comments
down below.
> (a) use irq domain for handling charger interrupts
> (b) use scaled adc value rather than raw value
> : replace iio_read_channel_raw() with
On Tue, Aug 14, 2012 at 02:32:50AM +, Kim, Milo wrote:
Patch v3.
Thanks for the driver! It looks great, mostly cosmetic comments
down below.
(a) use irq domain for handling charger interrupts
(b) use scaled adc value rather than raw value
: replace iio_read_channel_raw() with
Patch v3.
(a) use irq domain for handling charger interrupts
(b) use scaled adc value rather than raw value
: replace iio_read_channel_raw() with iio_read_channel_scale()
(c) clean up charger-platform-data code
(d) remove goto statement in _probe()
(e) name change : from
Patch v3.
(a) use irq domain for handling charger interrupts
(b) use scaled adc value rather than raw value
: replace iio_read_channel_raw() with iio_read_channel_scale()
(c) clean up charger-platform-data code
(d) remove goto statement in _probe()
(e) name change : from
6 matches
Mail list logo