On Wed, Oct 30, 2013 at 04:33:26PM +0100, Jean Delvare wrote:
> Hi Guenter,
>
> On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
> > On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
> > > Unrelated to this patch, but Guenter, I am worried about the MAX6696
> > > handling
On Wed, Oct 30, 2013 at 04:33:26PM +0100, Jean Delvare wrote:
> Hi Guenter,
>
> On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
> > On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
> > > Unrelated to this patch, but Guenter, I am worried about the MAX6696
> > > handling
Hi Guenter,
On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
> On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
> > Unrelated to this patch, but Guenter, I am worried about the MAX6696
> > handling here. I realize that I am the one who accepted your code, but
> > now it looks
Hi Guenter,
On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
Unrelated to this patch, but Guenter, I am worried about the MAX6696
handling here. I realize that I am the one who accepted your code, but
now it looks wrong.
On Wed, Oct 30, 2013 at 04:33:26PM +0100, Jean Delvare wrote:
Hi Guenter,
On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
Unrelated to this patch, but Guenter, I am worried about the MAX6696
handling here. I realize
On Wed, Oct 30, 2013 at 04:33:26PM +0100, Jean Delvare wrote:
Hi Guenter,
On Mon, 15 Jul 2013 10:33:22 -0700, Guenter Roeck wrote:
On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
Unrelated to this patch, but Guenter, I am worried about the MAX6696
handling here. I realize
Hi Wei,
On Wed, 17 Jul 2013 17:29:32 +0800, Wei Ni wrote:
> On 07/17/2013 04:28 PM, Jean Delvare wrote:
> > I do maintain the lm90 driver, so the decision is up to me. Guenter did
> > a preliminary review of your patches and I am grateful for that, but I
> > do not intend to wait for his return
On 07/17/2013 04:28 PM, Jean Delvare wrote:
> Hi Wei,
>
> On Wed, 17 Jul 2013 15:03:35 +0800, Wei Ni wrote:
>> On 07/16/2013 12:57 AM, Jean Delvare wrote:
>>> On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
>>>
>>> Regarding the subject: for me
Hi Wei,
On Wed, 17 Jul 2013 15:03:35 +0800, Wei Ni wrote:
> On 07/16/2013 12:57 AM, Jean Delvare wrote:
> > On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
> >> Add bit defines for the status register.
> >
> > Regarding the subject: for me these are constants, not macros. AFAIK
> > the term
On 07/17/2013 03:03 PM, Wei Ni wrote:
> On 07/16/2013 12:57 AM, Jean Delvare wrote:
>> Hi Wei, Guenter,
>>
>>> +
>>> + if ((status & 0x7f) == 0 && (status2 & 0xfe) == 0)
>>> + return false;
>>
>> It's a bit disappointing to not use the freshly introduced constants.
>> That being said I
On 07/16/2013 12:57 AM, Jean Delvare wrote:
> Hi Wei, Guenter,
>
> On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
>> Add bit defines for the status register.
>
> Regarding the subject: for me these are constants, not macros. AFAIK
> the term "macro" refers to defines with parameters only.
On 07/16/2013 12:57 AM, Jean Delvare wrote:
Hi Wei, Guenter,
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
Regarding the subject: for me these are constants, not macros. AFAIK
the term macro refers to defines with parameters only.
How about
On 07/17/2013 03:03 PM, Wei Ni wrote:
On 07/16/2013 12:57 AM, Jean Delvare wrote:
Hi Wei, Guenter,
+
+ if ((status 0x7f) == 0 (status2 0xfe) == 0)
+ return false;
It's a bit disappointing to not use the freshly introduced constants.
That being said I agree it would make the
Hi Wei,
On Wed, 17 Jul 2013 15:03:35 +0800, Wei Ni wrote:
On 07/16/2013 12:57 AM, Jean Delvare wrote:
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
Regarding the subject: for me these are constants, not macros. AFAIK
the term macro refers
On 07/17/2013 04:28 PM, Jean Delvare wrote:
Hi Wei,
On Wed, 17 Jul 2013 15:03:35 +0800, Wei Ni wrote:
On 07/16/2013 12:57 AM, Jean Delvare wrote:
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
Regarding the subject: for me these are constants,
Hi Wei,
On Wed, 17 Jul 2013 17:29:32 +0800, Wei Ni wrote:
On 07/17/2013 04:28 PM, Jean Delvare wrote:
I do maintain the lm90 driver, so the decision is up to me. Guenter did
a preliminary review of your patches and I am grateful for that, but I
do not intend to wait for his return to
On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
> Hi Wei, Guenter,
>
> On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
> > Add bit defines for the status register.
>
> Regarding the subject: for me these are constants, not macros. AFAIK
> the term "macro" refers to defines with
Hi Wei, Guenter,
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
> Add bit defines for the status register.
Regarding the subject: for me these are constants, not macros. AFAIK
the term "macro" refers to defines with parameters only.
> Signed-off-by: Wei Ni
> ---
> drivers/hwmon/lm90.c |
Hi Wei, Guenter,
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
Regarding the subject: for me these are constants, not macros. AFAIK
the term macro refers to defines with parameters only.
Signed-off-by: Wei Ni w...@nvidia.com
---
On Mon, Jul 15, 2013 at 06:57:27PM +0200, Jean Delvare wrote:
Hi Wei, Guenter,
On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote:
Add bit defines for the status register.
Regarding the subject: for me these are constants, not macros. AFAIK
the term macro refers to defines with parameters
Add bit defines for the status register.
Signed-off-by: Wei Ni
---
drivers/hwmon/lm90.c | 72 ++
1 file changed, 49 insertions(+), 23 deletions(-)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index 5f30f90..c90037f 100644
---
Add bit defines for the status register.
Signed-off-by: Wei Ni w...@nvidia.com
---
drivers/hwmon/lm90.c | 72 ++
1 file changed, 49 insertions(+), 23 deletions(-)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index 5f30f90..c90037f
22 matches
Mail list logo
