Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-09 Thread Baoquan He
On 04/09/18 at 09:02am, Dave Hansen wrote: > On 04/07/2018 11:50 PM, Baoquan He wrote: > >> Should the " = 0" instead be clearing SECTION_MARKED_PRESENT or > >> something? That would make it easier to match the code up with the code > >> that it is effectively undoing. > > > > Not sure if I

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-09 Thread Baoquan He
On 04/09/18 at 09:02am, Dave Hansen wrote: > On 04/07/2018 11:50 PM, Baoquan He wrote: > >> Should the " = 0" instead be clearing SECTION_MARKED_PRESENT or > >> something? That would make it easier to match the code up with the code > >> that it is effectively undoing. > > > > Not sure if I

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-09 Thread Dave Hansen
On 04/07/2018 11:50 PM, Baoquan He wrote: >> Should the " = 0" instead be clearing SECTION_MARKED_PRESENT or >> something? That would make it easier to match the code up with the code >> that it is effectively undoing. > > Not sure if I understand your question correctly. From memory_present(),

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-09 Thread Dave Hansen
On 04/07/2018 11:50 PM, Baoquan He wrote: >> Should the " = 0" instead be clearing SECTION_MARKED_PRESENT or >> something? That would make it easier to match the code up with the code >> that it is effectively undoing. > > Not sure if I understand your question correctly. From memory_present(),

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-08 Thread Baoquan He
Hi Dave, Thanks a lot for your careful reviewing! On 04/06/18 at 07:23am, Dave Hansen wrote: > On 02/27/2018 07:26 PM, Baoquan He wrote: > > In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system > > will allocate one continuous memory chunk for mem maps on one node and > >

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-08 Thread Baoquan He
Hi Dave, Thanks a lot for your careful reviewing! On 04/06/18 at 07:23am, Dave Hansen wrote: > On 02/27/2018 07:26 PM, Baoquan He wrote: > > In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system > > will allocate one continuous memory chunk for mem maps on one node and > >

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-06 Thread Dave Hansen
On 02/27/2018 07:26 PM, Baoquan He wrote: > In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system > will allocate one continuous memory chunk for mem maps on one node and > populate the relevant page tables to map memory section one by one. If > fail to populate for a certain mem

Re: [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-04-06 Thread Dave Hansen
On 02/27/2018 07:26 PM, Baoquan He wrote: > In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system > will allocate one continuous memory chunk for mem maps on one node and > populate the relevant page tables to map memory section one by one. If > fail to populate for a certain mem

[PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-02-27 Thread Baoquan He
In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system will allocate one continuous memory chunk for mem maps on one node and populate the relevant page tables to map memory section one by one. If fail to populate for a certain mem section, print warning and its ->section_mem_map

[PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing

2018-02-27 Thread Baoquan He
In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system will allocate one continuous memory chunk for mem maps on one node and populate the relevant page tables to map memory section one by one. If fail to populate for a certain mem section, print warning and its ->section_mem_map