Re: [PATCH v3 2/4] mmc: sdhci-pxav2: switch to managed clk and sdhci_pltfm_unregister()

2017-08-22 Thread Jisheng Zhang
On Mon, 21 Aug 2017 15:03:42 +0300 Adrian Hunter wrote: > On 15/08/17 18:45, Masahiro Yamada wrote: > > The difference between sdhci_pxav2_remove() and sdhci_pltfm_unregister() > > is clk_put(). It will go away by using the managed resource clk, then > > sdhci_pltfm_unregister() can be reused. >

Re: [PATCH v3 2/4] mmc: sdhci-pxav2: switch to managed clk and sdhci_pltfm_unregister()

2017-08-21 Thread Adrian Hunter
On 15/08/17 18:45, Masahiro Yamada wrote: > The difference between sdhci_pxav2_remove() and sdhci_pltfm_unregister() > is clk_put(). It will go away by using the managed resource clk, then > sdhci_pltfm_unregister() can be reused. > > Also, rename the jump labels to say what the goto does. (Codin

[PATCH v3 2/4] mmc: sdhci-pxav2: switch to managed clk and sdhci_pltfm_unregister()

2017-08-15 Thread Masahiro Yamada
The difference between sdhci_pxav2_remove() and sdhci_pltfm_unregister() is clk_put(). It will go away by using the managed resource clk, then sdhci_pltfm_unregister() can be reused. Also, rename the jump labels to say what the goto does. (Coding style suggested by Documentation/process/coding-st