Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Tejun Heo
Hello, On Tue, Sep 24, 2013 at 10:41:51AM +0800, Zhang Yanfei wrote: > I see. But I think memblock_set_alloc_above_kernel may lose the info > that we are doing bottom-up allocation. So my idea is we introduce > pure bottom-up allocation mode in previous patches and we use the > bottom-up allocatio

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Zhang Yanfei
Hello tejun, On 09/24/2013 04:21 AM, Tejun Heo wrote: > Hello, > > On Tue, Sep 24, 2013 at 02:07:13AM +0800, Zhang Yanfei wrote: >> Yes, I am following your advice in principle but kind of confused by >> something you said above. Where should the set_memblock_alloc_above_kernel >> be used? IMO, t

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Tejun Heo
Hello, On Tue, Sep 24, 2013 at 02:07:13AM +0800, Zhang Yanfei wrote: > Yes, I am following your advice in principle but kind of confused by > something you said above. Where should the set_memblock_alloc_above_kernel > be used? IMO, the function is like: > > find_in_range_node() > { > if (ok

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Zhang Yanfei
Hello tejun, On 09/23/2013 11:50 PM, Tejun Heo wrote: > Hello, > > Please separate out factoring out of top-down allocation. That change > is an equivalent conversion which shouldn't involve any functional > difference. Mixing that with introduction of new feature isn't a good > idea, so the pa

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Zhang Yanfei
Hello tejun, On 09/23/2013 11:50 PM, Tejun Heo wrote: > Hello, > > Please separate out factoring out of top-down allocation. That change > is an equivalent conversion which shouldn't involve any functional > difference. Mixing that with introduction of new feature isn't a good > idea, so the pa

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-23 Thread Tejun Heo
Hello, Please separate out factoring out of top-down allocation. That change is an equivalent conversion which shouldn't involve any functional difference. Mixing that with introduction of new feature isn't a good idea, so the patch split should be 1. split out top-down allocation from memblock_

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-15 Thread Zhang Yanfei
Hello toshi-san, On 09/14/2013 05:53 AM, Toshi Kani wrote: > On Fri, 2013-09-13 at 17:30 +0800, Tang Chen wrote: > : >> @@ -100,8 +180,7 @@ phys_addr_t __init_memblock >> memblock_find_in_range_node(phys_addr_t start, >> phys_addr_t end, phys_addr_t size, >>

Re: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-13 Thread Toshi Kani
On Fri, 2013-09-13 at 17:30 +0800, Tang Chen wrote: : > @@ -100,8 +180,7 @@ phys_addr_t __init_memblock > memblock_find_in_range_node(phys_addr_t start, > phys_addr_t end, phys_addr_t size, > phys_addr_t align, int nid) >

[PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.

2013-09-13 Thread Tang Chen
This patch modifies the memblock_find_in_range_node() to support two different allocation directions. After this patch, memblock will check memblock.current_direction, and decide in which direction to allocate memory. Now it supports two allocation directions: bottom up and top down. When directio