Re: [PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support

2021-03-22 Thread Srinivas Kandagatla
On 19/03/2021 15:23, Pierre-Louis Bossart wrote: +static void wcd_clsh_v3_set_hph_mode(struct snd_soc_component *component, +  int mode) +{ +    u8 val = 0; initialization not needed. I agree, will remove this in next spin. + +    switch (mode) { +    case

Re: [PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support

2021-03-19 Thread Pierre-Louis Bossart
+static void wcd_clsh_v3_set_hph_mode(struct snd_soc_component *component, + int mode) +{ + u8 val = 0; initialization not needed. + + switch (mode) { + case CLS_H_NORMAL: + val = 0x00; + break; + case

[PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support

2021-03-19 Thread Srinivas Kandagatla
>From WCD937X Class H controller has changed significantly, so add support to this new version for WCD937X and WCD938X Codecs. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wcd-clsh-v2.c | 350 - sound/soc/codecs/wcd-clsh-v2.h | 16 ++ 2 files changed,