Re: [PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-12 Thread Mateusz Kulikowski
On 10.05.2015 00:37, Joe Perches wrote: > On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote: >> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. >> Replace printk() with netdev_* if possible, pr_* in other cases. >> All pr_* use __func__ to easily trace message back to rtllib >

Re: [PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-12 Thread Mateusz Kulikowski
On 10.05.2015 00:37, Joe Perches wrote: On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote: Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. Replace printk() with netdev_* if possible, pr_* in other cases. All pr_* use __func__ to easily trace message back to rtllib It's

Re: [PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-09 Thread Joe Perches
On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote: > Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. > Replace printk() with netdev_* if possible, pr_* in other cases. > All pr_* use __func__ to easily trace message back to rtllib It's more common to use %s: and not %s(): but

[PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-09 Thread Mateusz Kulikowski
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. Replace printk() with netdev_* if possible, pr_* in other cases. All pr_* use __func__ to easily trace message back to rtllib Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-

Re: [PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-09 Thread Joe Perches
On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote: Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. Replace printk() with netdev_* if possible, pr_* in other cases. All pr_* use __func__ to easily trace message back to rtllib It's more common to use %s: and not %s(): but

[PATCH v3 20/33] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

2015-05-09 Thread Mateusz Kulikowski
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. Replace printk() with netdev_* if possible, pr_* in other cases. All pr_* use __func__ to easily trace message back to rtllib Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c