Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-12 Thread Mateusz Kulikowski
On 11.05.2015 15:22, Dan Carpenter wrote: > On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: (...) >> len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv); >> -erq->length = (len >= 0 ? len : 0); >> +if (len > U16_MAX) >> +

Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-12 Thread Mateusz Kulikowski
On 11.05.2015 15:22, Dan Carpenter wrote: On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: (...) len = crypt-ops-get_key(keybuf, SCM_KEY_LEN, NULL, crypt-priv); -erq-length = (len = 0 ? len : 0); +if (len U16_MAX) +netdev_err(ieee-dev, Too long key

Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: > Warninig is printed if precision is lost - it can't happen at moment as > all get_key implementations return either -1 or small buffers. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_wx.c | 5

Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: Warninig is printed if precision is lost - it can't happen at moment as all get_key implementations return either -1 or small buffers. Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com ---

[PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-09 Thread Mateusz Kulikowski
Warninig is printed if precision is lost - it can't happen at moment as all get_key implementations return either -1 or small buffers. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_wx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-09 Thread Mateusz Kulikowski
Warninig is printed if precision is lost - it can't happen at moment as all get_key implementations return either -1 or small buffers. Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com --- drivers/staging/rtl8192e/rtllib_wx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)