Re: [PATCH v3 3/3] Force all cpus to exit VMX root operation on crash/panic reliably

2020-07-06 Thread Sean Christopherson
On Sun, Jul 05, 2020 at 01:53:39PM -0700, Andy Lutomirski wrote: > On Sun, Jul 5, 2020 at 1:00 PM David P. Reed wrote: > > > > On Sunday, July 5, 2020 2:26pm, "Andy Lutomirski" said: > > > As a minor caveat, doing cr4_clear_bits() in NMI context is not really > > > okay, but we're about to

Re: [PATCH v3 3/3] Force all cpus to exit VMX root operation on crash/panic reliably

2020-07-05 Thread Andy Lutomirski
On Sun, Jul 5, 2020 at 1:00 PM David P. Reed wrote: > > > > On Sunday, July 5, 2020 2:26pm, "Andy Lutomirski" said: > > > On Sat, Jul 4, 2020 at 1:38 PM David P. Reed wrote: > >> > >> Fix the logic during crash/panic reboot on Intel processors that > >> can support VMX operation to ensure that

Re: [PATCH v3 3/3] Force all cpus to exit VMX root operation on crash/panic reliably

2020-07-05 Thread David P. Reed
On Sunday, July 5, 2020 2:26pm, "Andy Lutomirski" said: > On Sat, Jul 4, 2020 at 1:38 PM David P. Reed wrote: >> >> Fix the logic during crash/panic reboot on Intel processors that >> can support VMX operation to ensure that all processors are not >> in VMX root operation. Prior code made

Re: [PATCH v3 3/3] Force all cpus to exit VMX root operation on crash/panic reliably

2020-07-05 Thread Andy Lutomirski
On Sat, Jul 4, 2020 at 1:38 PM David P. Reed wrote: > > Fix the logic during crash/panic reboot on Intel processors that > can support VMX operation to ensure that all processors are not > in VMX root operation. Prior code made optimistic assumptions > about other cpus that would leave other cpus

[PATCH v3 3/3] Force all cpus to exit VMX root operation on crash/panic reliably

2020-07-04 Thread David P. Reed
Fix the logic during crash/panic reboot on Intel processors that can support VMX operation to ensure that all processors are not in VMX root operation. Prior code made optimistic assumptions about other cpus that would leave other cpus in VMX root operation depending on timing of crash/panic