Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-27 Thread Catalin Marinas
On Fri, Nov 27, 2015 at 11:36:30AM +0300, Andrey Ryabinin wrote: > 2015-11-25 23:39 GMT+03:00 Daniel Cashman : > > On 11/25/2015 04:06 AM, Catalin Marinas wrote: > >> For KASan, we ended up calculating KASAN_SHADOW_OFFSET in > >> arch/arm64/Makefile. What would the formula be for the above > >>

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-27 Thread Andrey Ryabinin
2015-11-25 23:39 GMT+03:00 Daniel Cashman : > On 11/25/2015 04:06 AM, Catalin Marinas wrote: >> On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: >>> On 11/23/2015 07:04 AM, Will Deacon wrote: On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > +config

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-27 Thread Catalin Marinas
On Fri, Nov 27, 2015 at 11:36:30AM +0300, Andrey Ryabinin wrote: > 2015-11-25 23:39 GMT+03:00 Daniel Cashman : > > On 11/25/2015 04:06 AM, Catalin Marinas wrote: > >> For KASan, we ended up calculating KASAN_SHADOW_OFFSET in > >> arch/arm64/Makefile. What would the formula be

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-27 Thread Andrey Ryabinin
2015-11-25 23:39 GMT+03:00 Daniel Cashman : > On 11/25/2015 04:06 AM, Catalin Marinas wrote: >> On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: >>> On 11/23/2015 07:04 AM, Will Deacon wrote: On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote:

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Daniel Cashman
On 11/25/2015 04:06 AM, Catalin Marinas wrote: > On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: >> On 11/23/2015 07:04 AM, Will Deacon wrote: >>> On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: +config ARCH_MMAP_RND_BITS_MAX + default 20 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Daniel Cashman
On 11/24/2015 08:26 PM, Michael Ellerman wrote: > On Mon, 2015-11-23 at 10:55 -0800, Daniel Cashman wrote: >> On 11/23/2015 07:04 AM, Will Deacon wrote: >>> On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: +config ARCH_MMAP_RND_BITS_MAX + default 20 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Catalin Marinas
On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: > On 11/23/2015 07:04 AM, Will Deacon wrote: > > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > >> +config ARCH_MMAP_RND_BITS_MAX > >> + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 Where is ARCH_VA_BITS

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Daniel Cashman
On 11/24/2015 08:26 PM, Michael Ellerman wrote: > On Mon, 2015-11-23 at 10:55 -0800, Daniel Cashman wrote: >> On 11/23/2015 07:04 AM, Will Deacon wrote: >>> On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: +config ARCH_MMAP_RND_BITS_MAX + default 20 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Daniel Cashman
On 11/25/2015 04:06 AM, Catalin Marinas wrote: > On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: >> On 11/23/2015 07:04 AM, Will Deacon wrote: >>> On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: +config ARCH_MMAP_RND_BITS_MAX + default 20 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-25 Thread Catalin Marinas
On Mon, Nov 23, 2015 at 10:55:16AM -0800, Daniel Cashman wrote: > On 11/23/2015 07:04 AM, Will Deacon wrote: > > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > >> +config ARCH_MMAP_RND_BITS_MAX > >> + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 Where is ARCH_VA_BITS

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-24 Thread Michael Ellerman
On Mon, 2015-11-23 at 10:55 -0800, Daniel Cashman wrote: > On 11/23/2015 07:04 AM, Will Deacon wrote: > > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > > > +config ARCH_MMAP_RND_BITS_MAX > > > + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 > > > + default 24 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-24 Thread Michael Ellerman
On Mon, 2015-11-23 at 10:55 -0800, Daniel Cashman wrote: > On 11/23/2015 07:04 AM, Will Deacon wrote: > > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > > > +config ARCH_MMAP_RND_BITS_MAX > > > + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 > > > + default 24 if

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-23 Thread Daniel Cashman
On 11/23/2015 07:04 AM, Will Deacon wrote: > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: >> +config ARCH_MMAP_RND_BITS_MAX >> + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 >> + default 24 if ARCH_VA_BITS=39 >> + default 23 if ARM64_64K_PAGES &&

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-23 Thread Will Deacon
On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > From: dcashman > > arm64: arch_mmap_rnd() uses STACK_RND_MASK to generate the > random offset for the mmap base address. This value represents a > compromise between increased ASLR effectiveness and avoiding > address-space

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-23 Thread Daniel Cashman
On 11/23/2015 07:04 AM, Will Deacon wrote: > On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: >> +config ARCH_MMAP_RND_BITS_MAX >> + default 20 if ARM64_64K_PAGES && ARCH_VA_BITS=39 >> + default 24 if ARCH_VA_BITS=39 >> + default 23 if ARM64_64K_PAGES &&

Re: [PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-23 Thread Will Deacon
On Wed, Nov 18, 2015 at 03:20:07PM -0800, Daniel Cashman wrote: > From: dcashman > > arm64: arch_mmap_rnd() uses STACK_RND_MASK to generate the > random offset for the mmap base address. This value represents a > compromise between increased ASLR effectiveness and avoiding

[PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-18 Thread Daniel Cashman
From: dcashman arm64: arch_mmap_rnd() uses STACK_RND_MASK to generate the random offset for the mmap base address. This value represents a compromise between increased ASLR effectiveness and avoiding address-space fragmentation. Replace it with a Kconfig option, which is sensibly bounded, so

[PATCH v3 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

2015-11-18 Thread Daniel Cashman
From: dcashman arm64: arch_mmap_rnd() uses STACK_RND_MASK to generate the random offset for the mmap base address. This value represents a compromise between increased ASLR effectiveness and avoiding address-space fragmentation. Replace it with a Kconfig option, which is