Re: [PATCH v3 3/5] perf c2c: Refactor display filter

2021-01-13 Thread Leo Yan
Hi Joe, On Wed, Jan 13, 2021 at 11:35:23PM -0800, Joe Perches wrote: > On Thu, 2021-01-14 at 11:39 +0800, Leo Yan wrote: > > When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm), > > macro FILTER_HITM is to filter out the cache line entries if its > > overhead is less than 1%. > >

Re: [PATCH v3 3/5] perf c2c: Refactor display filter

2021-01-13 Thread Joe Perches
On Thu, 2021-01-14 at 11:39 +0800, Leo Yan wrote: > When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm), > macro FILTER_HITM is to filter out the cache line entries if its > overhead is less than 1%. > > This patch introduces static function filter_display() to replace macro; > and

[PATCH v3 3/5] perf c2c: Refactor display filter

2021-01-13 Thread Leo Yan
When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm), macro FILTER_HITM is to filter out the cache line entries if its overhead is less than 1%. This patch introduces static function filter_display() to replace macro; and refines its parameter with more flexbile way, rather than