Re: [PATCH v3 3/6] KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_idx

2019-10-23 Thread Jim Mattson
On Tue, Oct 22, 2019 at 1:12 AM Like Xu wrote: > > The leagcy pmu_ops->msr_idx_to_pmc is only called in kvm_pmu_rdpmc, so > this name is restrictedly limited to rdpmc_idx which could be indexed > exactly to a kvm_pmc. Let's restrict its semantic by renaming the > existing msr_idx_to_pmc to rdpmc_i

[PATCH v3 3/6] KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_idx

2019-10-22 Thread Like Xu
The leagcy pmu_ops->msr_idx_to_pmc is only called in kvm_pmu_rdpmc, so this name is restrictedly limited to rdpmc_idx which could be indexed exactly to a kvm_pmc. Let's restrict its semantic by renaming the existing msr_idx_to_pmc to rdpmc_idx_to_pmc, and is_valid_msr_idx to is_valid_rdpmc_idx (lik