Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-21 Thread Cristian Ciocaltea
On Mon, Dec 21, 2020 at 01:18:01PM +0100, Linus Walleij wrote: > On Mon, Dec 21, 2020 at 12:59 PM Cristian Ciocaltea > wrote: > > > enum atc260x_ver { > > ATC260X_A = 0, > > ATC260X_B, > > ATC260X_C, > > ATC260X_D, > > ATC260X_E, > > ATC260X_F, > >

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-21 Thread Linus Walleij
On Mon, Dec 21, 2020 at 12:59 PM Cristian Ciocaltea wrote: > enum atc260x_ver { > ATC260X_A = 0, > ATC260X_B, > ATC260X_C, > ATC260X_D, > ATC260X_E, > ATC260X_F, > ATC260X_G, > ATC260X_H, > }; This makes it look like the driver is

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-21 Thread Cristian Ciocaltea
On Mon, Dec 21, 2020 at 08:10:15AM +, Lee Jones wrote: > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > On Fri, Dec 18, 2020 at 01:21:39PM +, Lee Jones wrote: > > > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > > > > > Hi Lee, > > > > > > > > Thank you for the detailed

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-21 Thread Lee Jones
On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > On Fri, Dec 18, 2020 at 01:21:39PM +, Lee Jones wrote: > > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > > > Hi Lee, > > > > > > Thank you for the detailed review! > > > > > > I will prepare a new revision, but there are still a

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-18 Thread Cristian Ciocaltea
On Fri, Dec 18, 2020 at 01:21:39PM +, Lee Jones wrote: > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > Hi Lee, > > > > Thank you for the detailed review! > > > > I will prepare a new revision, but there are still a couple of open > > points.. > > Could you please snip your replies,

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-18 Thread Lee Jones
On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > Hi Lee, > > Thank you for the detailed review! > > I will prepare a new revision, but there are still a couple of open > points.. Could you please snip your replies, leaving only the open points. Scrolling through lots of empty quotes or "done"

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-17 Thread Cristian Ciocaltea
Hi Lee, Thank you for the detailed review! I will prepare a new revision, but there are still a couple of open points.. On Wed, Dec 16, 2020 at 10:10:00AM +, Lee Jones wrote: > On Sun, 06 Dec 2020, Cristian Ciocaltea wrote: > > > Add initial support for the Actions Semi ATC260x PMICs.

Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-16 Thread Lee Jones
On Sun, 06 Dec 2020, Cristian Ciocaltea wrote: > Add initial support for the Actions Semi ATC260x PMICs. ATC260x series > PMICs integrates Audio Codec, Power management, Clock generation and "which integrates" > GPIO controller blocks. > > For the moment this driver only supports Regulator,

[PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

2020-12-05 Thread Cristian Ciocaltea
Add initial support for the Actions Semi ATC260x PMICs. ATC260x series PMICs integrates Audio Codec, Power management, Clock generation and GPIO controller blocks. For the moment this driver only supports Regulator, Poweroff and Onkey functionalities for the ATC2603C and ATC2609A chip variants.