Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-06-03 Thread Roman Gushchin
On Mon, Jun 03, 2019 at 07:35:28PM +0200, Uladzislau Rezki wrote: > Hello, Roman! > > On Wed, May 29, 2019 at 04:26:43PM +, Roman Gushchin wrote: > > On Wed, May 29, 2019 at 03:58:17PM +0200, Uladzislau Rezki wrote: > > > Hello, Roman! > > > > > > > > Move the BUG_ON()/RB_EMPTY_NODE() check

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-06-03 Thread Uladzislau Rezki
Hello, Roman! On Wed, May 29, 2019 at 04:26:43PM +, Roman Gushchin wrote: > On Wed, May 29, 2019 at 03:58:17PM +0200, Uladzislau Rezki wrote: > > Hello, Roman! > > > > > > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > > > > function, it means if an empty node gets freed it is a

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-29 Thread Roman Gushchin
On Wed, May 29, 2019 at 03:58:17PM +0200, Uladzislau Rezki wrote: > Hello, Roman! > > > > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > > > function, it means if an empty node gets freed it is a BUG > > > thus is considered as faulty behaviour. > > > > It's not exactly clear from

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-29 Thread Uladzislau Rezki
Hello, Roman! > > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > > function, it means if an empty node gets freed it is a BUG > > thus is considered as faulty behaviour. > > It's not exactly clear from the description, why it's better. > It is rather about if "unlink" happens on

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-28 Thread Roman Gushchin
On Mon, May 27, 2019 at 11:38:42AM +0200, Uladzislau Rezki (Sony) wrote: > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > function, it means if an empty node gets freed it is a BUG > thus is considered as faulty behaviour. It's not exactly clear from the description, why it's better.

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-27 Thread Uladzislau Rezki
> > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > > function, it means if an empty node gets freed it is a BUG > > thus is considered as faulty behaviour. > > Can we switch it to a WARN_ON(). We are trying to remove all BUG_ON()s. > If a user wants to crash on warning, there's a

Re: [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-27 Thread Steven Rostedt
On Mon, 27 May 2019 11:38:42 +0200 "Uladzislau Rezki (Sony)" wrote: > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > function, it means if an empty node gets freed it is a BUG > thus is considered as faulty behaviour. Can we switch it to a WARN_ON(). We are trying to remove all

[PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

2019-05-27 Thread Uladzislau Rezki (Sony)
Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() function, it means if an empty node gets freed it is a BUG thus is considered as faulty behaviour. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-)