Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-09 Thread Wolfram Sang
> > >> * moved sysfs device attributes to watchdog_dev.c, this required to > > >> add exported watchdog_pretimeout_governor_name() interface > > > > > > Why this move? Before, all the pretimeout stuff was nicely encapsulated > > > in its own file which could be compiled out. Now things are

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-09 Thread Wolfram Sang
> > >> * moved sysfs device attributes to watchdog_dev.c, this required to > > >> add exported watchdog_pretimeout_governor_name() interface > > > > > > Why this move? Before, all the pretimeout stuff was nicely encapsulated > > > in its own file which could be compiled out. Now things are

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-09 Thread Wolfram Sang
> >> * removed support of sleepable watchdog pretimeout governors > > > > This does. > > Same as above. Just to make sure: I meant this does make reviewing easier since the bottom half handling is the biggest thing to discuss and it is good to seperate it out. signature.asc Description: PGP

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-09 Thread Wolfram Sang
> >> * removed support of sleepable watchdog pretimeout governors > > > > This does. > > Same as above. Just to make sure: I meant this does make reviewing easier since the bottom half handling is the biggest thing to discuss and it is good to seperate it out. signature.asc Description: PGP

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 05:08:09PM +0300, Vladimir Zapolskiy wrote: > Hi Wolfram, > > On 08.06.2016 09:54, Wolfram Sang wrote: > > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > >> The change adds a simple watchdog pretimeout framework infrastructure, > >> its purpose is to

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 05:08:09PM +0300, Vladimir Zapolskiy wrote: > Hi Wolfram, > > On 08.06.2016 09:54, Wolfram Sang wrote: > > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > >> The change adds a simple watchdog pretimeout framework infrastructure, > >> its purpose is to

Re: kbuild: default n removals? (was: Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework)

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 08:38:52AM -0700, Joe Perches wrote: > (Adding Michal Marek and linux-kbuild) > > On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: > > On 08.06.2016 16:53, Guenter Roeck wrote: > > > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > > > > > > +comment

Re: kbuild: default n removals? (was: Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework)

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 08:38:52AM -0700, Joe Perches wrote: > (Adding Michal Marek and linux-kbuild) > > On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: > > On 08.06.2016 16:53, Guenter Roeck wrote: > > > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > > > > > > +comment

kbuild: default n removals? (was: Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework)

2016-06-08 Thread Joe Perches
(Adding Michal Marek and linux-kbuild) On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: > On 08.06.2016 16:53, Guenter Roeck wrote: > > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > > > > > +comment "Watchdog Pretimeout Governors" > > > > > + > > > > > +config

kbuild: default n removals? (was: Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework)

2016-06-08 Thread Joe Perches
(Adding Michal Marek and linux-kbuild) On Wed, 2016-06-08 at 18:11 +0300, Vladimir Zapolskiy wrote: > On 08.06.2016 16:53, Guenter Roeck wrote: > > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > > > > > +comment "Watchdog Pretimeout Governors" > > > > > + > > > > > +config

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 16:53, Guenter Roeck wrote: > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > +comment "Watchdog Pretimeout Governors" + +config WATCHDOG_PRETIMEOUT_GOV + bool "Enable watchdog pretimeout governors" + default n >>> >>> I don't think 'default n" is

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 16:53, Guenter Roeck wrote: > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > +comment "Watchdog Pretimeout Governors" + +config WATCHDOG_PRETIMEOUT_GOV + bool "Enable watchdog pretimeout governors" + default n >>> >>> I don't think 'default n" is

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:54, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >> pretimeout events,

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:54, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >> pretimeout events,

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Guenter Roeck
On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: +comment "Watchdog Pretimeout Governors" + +config WATCHDOG_PRETIMEOUT_GOV + bool "Enable watchdog pretimeout governors" + default n I don't think 'default n" is needed. No strict objections, but probably 'default n' may save

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Guenter Roeck
On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: +comment "Watchdog Pretimeout Governors" + +config WATCHDOG_PRETIMEOUT_GOV + bool "Enable watchdog pretimeout governors" + default n I don't think 'default n" is needed. No strict objections, but probably 'default n' may save

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Guenter, On 08.06.2016 00:43, Guenter Roeck wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >> pretimeout events,

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Guenter, On 08.06.2016 00:43, Guenter Roeck wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >> pretimeout events,

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Wolfram Sang
On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > The change adds a simple watchdog pretimeout framework infrastructure, > its purpose is to allow users to select a desired handling of watchdog > pretimeout events, which may be generated by some watchdog devices. > > A user

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Wolfram Sang
On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > The change adds a simple watchdog pretimeout framework infrastructure, > its purpose is to allow users to select a desired handling of watchdog > pretimeout events, which may be generated by some watchdog devices. > > A user

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Guenter Roeck
On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > The change adds a simple watchdog pretimeout framework infrastructure, > its purpose is to allow users to select a desired handling of watchdog > pretimeout events, which may be generated by some watchdog devices. > > A user

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Guenter Roeck
On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: > The change adds a simple watchdog pretimeout framework infrastructure, > its purpose is to allow users to select a desired handling of watchdog > pretimeout events, which may be generated by some watchdog devices. > > A user

[PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
The change adds a simple watchdog pretimeout framework infrastructure, its purpose is to allow users to select a desired handling of watchdog pretimeout events, which may be generated by some watchdog devices. A user selects a default watchdog pretimeout governor during compilation stage.

[PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
The change adds a simple watchdog pretimeout framework infrastructure, its purpose is to allow users to select a desired handling of watchdog pretimeout events, which may be generated by some watchdog devices. A user selects a default watchdog pretimeout governor during compilation stage.