Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Andy Shevchenko
On Sun, Jul 1, 2018 at 11:41 AM, Manivannan Sadhasivam wrote: > On Sun, Jul 01, 2018 at 01:43:33PM +0530, Manivannan Sadhasivam wrote: >> On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: >> > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam >> > wrote: >> > > Add Actions

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Andy Shevchenko
On Sun, Jul 1, 2018 at 11:41 AM, Manivannan Sadhasivam wrote: > On Sun, Jul 01, 2018 at 01:43:33PM +0530, Manivannan Sadhasivam wrote: >> On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: >> > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam >> > wrote: >> > > Add Actions

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
On Sun, Jul 01, 2018 at 01:43:33PM +0530, Manivannan Sadhasivam wrote: > Hi Andy, > > On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > > wrote: > > > Add Actions Semiconductor Owl family S900 I2C driver. > > > > Thanks

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
On Sun, Jul 01, 2018 at 01:43:33PM +0530, Manivannan Sadhasivam wrote: > Hi Andy, > > On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > > wrote: > > > Add Actions Semiconductor Owl family S900 I2C driver. > > > > Thanks

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Andy, On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semiconductor Owl family S900 I2C driver. > > Thanks for an update. Few left comments and it would LGTM. > Thanks :) > > +static int

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Andy, On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semiconductor Owl family S900 I2C driver. > > Thanks for an update. Few left comments and it would LGTM. > Thanks :) > > +static int

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Peter, On Sun, Jul 01, 2018 at 06:57:54AM +0200, Peter Rosin wrote: > On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam > wrote: > >Add Actions Semiconductor Owl family S900 I2C driver. > > > >Signed-off-by: Manivannan Sadhasivam > >--- > > drivers/i2c/busses/Kconfig | 7 + >

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Peter, On Sun, Jul 01, 2018 at 06:57:54AM +0200, Peter Rosin wrote: > On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam > wrote: > >Add Actions Semiconductor Owl family S900 I2C driver. > > > >Signed-off-by: Manivannan Sadhasivam > >--- > > drivers/i2c/busses/Kconfig | 7 + >

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Peter Rosin
On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam wrote: >Add Actions Semiconductor Owl family S900 I2C driver. > >Signed-off-by: Manivannan Sadhasivam >--- > drivers/i2c/busses/Kconfig | 7 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-owl.c | 477

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Peter Rosin
On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam wrote: >Add Actions Semiconductor Owl family S900 I2C driver. > >Signed-off-by: Manivannan Sadhasivam >--- > drivers/i2c/busses/Kconfig | 7 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-owl.c | 477

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Andy Shevchenko
On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam wrote: > Add Actions Semiconductor Owl family S900 I2C driver. Thanks for an update. Few left comments and it would LGTM. > +static int owl_i2c_reset(struct owl_i2c_dev *i2c_dev) > +{ > + mdelay(1); But now, since it's not used in

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Andy Shevchenko
On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam wrote: > Add Actions Semiconductor Owl family S900 I2C driver. Thanks for an update. Few left comments and it would LGTM. > +static int owl_i2c_reset(struct owl_i2c_dev *i2c_dev) > +{ > + mdelay(1); But now, since it's not used in

[PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Add Actions Semiconductor Owl family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 477 +++ 3 files changed, 485 insertions(+) create mode

[PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Add Actions Semiconductor Owl family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 477 +++ 3 files changed, 485 insertions(+) create mode