Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-09 Thread Robert Jarzmik
Ezequiel Garcia writes: >>> Which flash do you have there? >> The one with 0xba20 id as I said, which is AFAIK a Numonyx NAND02GR4B2C. >> > > $ grep "0xBA" drivers/mtd/nand/nand_ids.c > EXTENDED_ID_NAND("NAND 256MiB 1,8V 16-bit", 0xBA, 256, LP_OPTIONS16), > > Seems already supported by the NAND

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-09 Thread Ezequiel Garcia
On 03/08/2015 07:19 PM, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >>> I think you'll kill the zylonite board, and I'll nack it if that's the >>> case. At >>> least that's what happened when I tried to use onfi default values last >>> time in >>> barebox development. >>> >>> I can test y

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-08 Thread Robert Jarzmik
Ezequiel Garcia writes: >> I think you'll kill the zylonite board, and I'll nack it if that's the case. >> At >> least that's what happened when I tried to use onfi default values last time >> in >> barebox development. >> >> I can test your changes, but if the specific zylonite nand (ie. nand

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-08 Thread Ezequiel Garcia
On 03/08/2015 02:14 PM, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> Hi Antoine, >> >> On 03/05/2015 08:31 AM, Antoine Tenart wrote: >> [..] >>> + >>> +static struct pxa3xx_nand_flash berlin_builtin_flash_types[] = { >>> +{ "4GiB 8-bit",0xd7ec, 128, 8192, 8, 8, 4096 }, >>> +{ }, >>

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-08 Thread Robert Jarzmik
Ezequiel Garcia writes: > Hi Antoine, > > On 03/05/2015 08:31 AM, Antoine Tenart wrote: > [..] >> + >> +static struct pxa3xx_nand_flash berlin_builtin_flash_types[] = { >> +{ "4GiB 8-bit",0xd7ec, 128, 8192, 8, 8, 4096 }, >> +{ }, > > IMHO, supporting a specific flash shouldn't be part of th

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-06 Thread Ezequiel Garcia
Hi Antoine, On 03/05/2015 08:31 AM, Antoine Tenart wrote: [..] > + > +static struct pxa3xx_nand_flash berlin_builtin_flash_types[] = { > +{ "4GiB 8-bit",0xd7ec, 128, 8192, 8, 8, 4096 }, > +{ }, IMHO, supporting a specific flash shouldn't be part of this patch. In any case, why do you need

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-05 Thread Antoine Tenart
Thomas, On Thu, Mar 05, 2015 at 02:00:00PM +0100, Thomas Petazzoni wrote: > On Thu, 5 Mar 2015 12:31:21 +0100, Antoine Tenart wrote: > > > struct pxa3xx_nand_host { > > @@ -253,6 +258,12 @@ static struct pxa3xx_nand_flash builtin_flash_types[] > > = { > > { "512MiB 8-bit", 0xdc2c, 64, 2048,

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-05 Thread Thomas Petazzoni
Dear Antoine Tenart, On Thu, 5 Mar 2015 12:31:21 +0100, Antoine Tenart wrote: > struct pxa3xx_nand_host { > @@ -253,6 +258,12 @@ static struct pxa3xx_nand_flash builtin_flash_types[] = { > { "512MiB 8-bit", 0xdc2c, 64, 2048, 8, 8, 4096 }, > { "512MiB 16-bit", 0xcc2c, 64, 2048, 16, 16, 40

[PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-05 Thread Antoine Tenart
The nand controller on Marvell Berlin SoC reuse the pxa3xx nand driver as it quite close. The process of sending commands can be compared to the one of the Marvell armada 370: read and write commands are done in chunks. But the Berlin nand controller has some other specificities which require some