Re: [PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Joonsoo Kim
On Tue, Jul 01, 2014 at 03:15:47PM -0700, Andrew Morton wrote: > On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim wrote: > > > -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t > > gfp) > > +static struct alien_cache *__alloc_alien_cache(int node, int entries, > > +

Re: [PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Andrew Morton
On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim wrote: > -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp) > +static struct alien_cache *__alloc_alien_cache(int node, int entries, > + int batch, gfp_t gfp) > +{ > + int

[PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Joonsoo Kim
Currently, we use array_cache for alien_cache. Although they are mostly similar, there is one difference, that is, need for spinlock. We don't need spinlock for array_cache itself, but to use array_cache for alien_cache, array_cache structure should have spinlock. This is needless overhead, so

[PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Joonsoo Kim
Currently, we use array_cache for alien_cache. Although they are mostly similar, there is one difference, that is, need for spinlock. We don't need spinlock for array_cache itself, but to use array_cache for alien_cache, array_cache structure should have spinlock. This is needless overhead, so

Re: [PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Andrew Morton
On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp) +static struct alien_cache *__alloc_alien_cache(int node, int entries, + int batch, gfp_t gfp)

Re: [PATCH v3 5/9] slab: introduce alien_cache

2014-07-01 Thread Joonsoo Kim
On Tue, Jul 01, 2014 at 03:15:47PM -0700, Andrew Morton wrote: On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp) +static struct alien_cache *__alloc_alien_cache(int node, int