Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; > > > > + /* Map and check

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; > > > > + /* Map and check

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Julius Werner
On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > This function checks the header for sanity, registers a bus, and > populates devices for each coreboot table entry. Let's just populate > devices here and pull the other bits up into the caller so that this > function can be repurposed for

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Julius Werner
On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > This function checks the header for sanity, registers a bus, and > populates devices for each coreboot table entry. Let's just populate > devices here and pull the other bits up into the caller so that this > function can be repurposed for

[PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
This function checks the header for sanity, registers a bus, and populates devices for each coreboot table entry. Let's just populate devices here and pull the other bits up into the caller so that this function can be repurposed for pure device creation and registration. We can devm()ify the

[PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
This function checks the header for sanity, registers a bus, and populates devices for each coreboot table entry. Let's just populate devices here and pull the other bits up into the caller so that this function can be repurposed for pure device creation and registration. We can devm()ify the