Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Tue, May 31, 2016 at 9:34 AM, Gerd Hoffmann wrote: > Hi, > >> > Right now the virtual outputs are linked to drm_crtc. To apply any >> > changes I need to lookup the crtc to figure which virtual output should >> > be updated. > >> > So, setting active_only should make sure

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Tue, May 31, 2016 at 9:34 AM, Gerd Hoffmann wrote: > Hi, > >> > Right now the virtual outputs are linked to drm_crtc. To apply any >> > changes I need to lookup the crtc to figure which virtual output should >> > be updated. > >> > So, setting active_only should make sure I have a valid

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > Right now the virtual outputs are linked to drm_crtc. To apply any > > changes I need to lookup the crtc to figure which virtual output should > > be updated. > > So, setting active_only should make sure I have a valid crtc pointer on > > plane updates, right? It probably also skips

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > Right now the virtual outputs are linked to drm_crtc. To apply any > > changes I need to lookup the crtc to figure which virtual output should > > be updated. > > So, setting active_only should make sure I have a valid crtc pointer on > > plane updates, right? It probably also skips

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Tue, May 31, 2016 at 8:18 AM, Gerd Hoffmann wrote: >> > https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html >> >> Hm, smells more like virtio isn't too happy with the default ordering of >> the commit operation. The default is: >> >> - Disable any

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Tue, May 31, 2016 at 8:18 AM, Gerd Hoffmann wrote: >> > https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html >> >> Hm, smells more like virtio isn't too happy with the default ordering of >> the commit operation. The default is: >> >> - Disable any crtc/encoders that need to

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html > > Hm, smells more like virtio isn't too happy with the default ordering of > the commit operation. The default is: > > - Disable any crtc/encoders that need to be disabled/change. > - Bash new plane setup into hw.

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html > > Hm, smells more like virtio isn't too happy with the default ordering of > the commit operation. The default is: > > - Disable any crtc/encoders that need to be disabled/change. > - Bash new plane setup into hw.

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Mon, May 30, 2016 at 02:06:50PM +0200, Gerd Hoffmann wrote: > Hi, > > > > But I'll take you up on the implied offer to help out and test ;-) > > > > git://people.freedesktop.org/~danvet/drm stuff > > Tried that branch. > > > Would be really awesome if you could test this on virtio. Note

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Mon, May 30, 2016 at 02:06:50PM +0200, Gerd Hoffmann wrote: > Hi, > > > > But I'll take you up on the implied offer to help out and test ;-) > > > > git://people.freedesktop.org/~danvet/drm stuff > > Tried that branch. > > > Would be really awesome if you could test this on virtio. Note

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > But I'll take you up on the implied offer to help out and test ;-) > > git://people.freedesktop.org/~danvet/drm stuff Tried that branch. > Would be really awesome if you could test this on virtio. Note that the > new nonblocking helpers require that your atomic backend gets the drm >

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Hi, > > But I'll take you up on the implied offer to help out and test ;-) > > git://people.freedesktop.org/~danvet/drm stuff Tried that branch. > Would be really awesome if you could test this on virtio. Note that the > new nonblocking helpers require that your atomic backend gets the drm >

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, May 27, 2016 at 09:50:27AM +0200, Daniel Vetter wrote: > On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > > > Signed-off-by: Gerd

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, May 27, 2016 at 09:50:27AM +0200, Daniel Vetter wrote: > On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > > > Signed-off-by: Gerd Hoffmann > > > > > >

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > > So I entirely missed this, but this

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > > So I entirely missed this, but this isn't really how to implement > >

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > So I entirely missed this, but this isn't really how to implement > page_flip for an atomic driver. Working on

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > So I entirely missed this, but this isn't really how to implement > page_flip for an atomic driver. Working on some stuff and will hack up > a

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann So I entirely missed this, but this isn't really how to implement page_flip for an atomic driver. Working on some stuff and will hack up a likely totally broken patch, but

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann So I entirely missed this, but this isn't really how to implement page_flip for an atomic driver. Working on some stuff and will hack up a likely totally broken patch, but should be enough as guideline. -Daniel

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 49 ++-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index c9c1427..f545913 100644 ---

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 49 ++-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index