Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi David, On 03/30/2016 09:31 AM, David Howells wrote: >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> > + >> > + err = -ENOKEY; >> > + if (IS_ERR(keyring)) >> > + goto out; >> > + >> > + pkey = keyring->payload.data[asym_crypto]; > NAK. This is liable to crash in

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi David, On 03/30/2016 09:31 AM, David Howells wrote: >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> > + >> > + err = -ENOKEY; >> > + if (IS_ERR(keyring)) >> > + goto out; >> > + >> > + pkey = keyring->payload.data[asym_crypto]; > NAK. This is liable to crash in

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

> Tadeusz Struk wrote: > >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> + >> +err = -ENOKEY; >> +if (IS_ERR(keyring)) >> +goto out; >> + >> +pkey = keyring->payload.data[asym_crypto]; > > NAK. This is liable to crash in

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

> Tadeusz Struk wrote: > >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> + >> +err = -ENOKEY; >> +if (IS_ERR(keyring)) >> +goto out; >> + >> +pkey = keyring->payload.data[asym_crypto]; > > NAK. This is liable to crash in future. You may not assume

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

> Tadeusz Struk wrote: > >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> + >> +err = -ENOKEY; >> +if (IS_ERR(keyring)) >> +goto out; >> + >> +pkey = keyring->payload.data[asym_crypto]; > > NAK. This is liable to crash in

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

> Tadeusz Struk wrote: > >> +keyring = request_key(_type_asymmetric, key_name, NULL); >> + >> +err = -ENOKEY; >> +if (IS_ERR(keyring)) >> +goto out; >> + >> +pkey = keyring->payload.data[asym_crypto]; > > NAK. This is liable to crash in future. You may not assume

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Tadeusz Struk wrote: > + keyring = request_key(_type_asymmetric, key_name, NULL); > + > + err = -ENOKEY; > + if (IS_ERR(keyring)) > + goto out; > + > + pkey = keyring->payload.data[asym_crypto]; NAK. This is liable to crash in future. You

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Tadeusz Struk wrote: > + keyring = request_key(_type_asymmetric, key_name, NULL); > + > + err = -ENOKEY; > + if (IS_ERR(keyring)) > + goto out; > + > + pkey = keyring->payload.data[asym_crypto]; NAK. This is liable to crash in future. You may not assume that you

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi, On 03/29/2016 06:49 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on v4.6-rc1] > [also build test ERROR on next-20160329] > [cannot apply to crypto/master] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > >

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi, On 03/29/2016 06:49 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on v4.6-rc1] > [also build test ERROR on next-20160329] > [cannot apply to crypto/master] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > >

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

Hi Tadeusz, [auto build test ERROR on v4.6-rc1] [also build test ERROR on next-20160329] [cannot apply to crypto/master] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

[PATCH v3 7/7] crypto: AF_ALG - add support for key_id

This patch adds support for asymmetric key type to AF_ALG. It will work as follows: A new PF_ALG socket options are added on top of existing ALG_SET_KEY and ALG_SET_PUBKEY, namely ALG_SET_KEY_ID and ALG_SET_PUBKEY_ID for setting public and private keys respectively. When these new options will be

[PATCH v3 7/7] crypto: AF_ALG - add support for key_id

This patch adds support for asymmetric key type to AF_ALG. It will work as follows: A new PF_ALG socket options are added on top of existing ALG_SET_KEY and ALG_SET_PUBKEY, namely ALG_SET_KEY_ID and ALG_SET_PUBKEY_ID for setting public and private keys respectively. When these new options will be