Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-19 Thread Johannes Berg
> +static u64 debugfs_s8_get(void *data) > struct simple_attr { > - u64 (*get)(void *); > + unsigned long long (*get)(void *); That seems wrong. Wouldn't you have to declare all the _get functions with unsigned long long too now to avoid trouble on systems where u64 != unsigned long

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-19 Thread John W. Linville
On Wed, Dec 19, 2007 at 10:20:16AM +0100, Stefano Brivio wrote: > On Tue, 18 Dec 2007 22:45:10 -0800 > Greg KH <[EMAIL PROTECTED]> wrote: > > > On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: > > > here comes an implementation of debugfs_create_s{8,16,32,64} which avoids > > >

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-19 Thread Stefano Brivio
On Tue, 18 Dec 2007 22:45:10 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: > > Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to > > remove > > a cast in libfs. > > > > Cc: Johannes Berg <[EMAIL PROTECTED]> > >

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-19 Thread Stefano Brivio
On Tue, 18 Dec 2007 22:45:10 -0800 Greg KH [EMAIL PROTECTED] wrote: On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg [EMAIL PROTECTED] To: Greg

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-19 Thread John W. Linville
On Wed, Dec 19, 2007 at 10:20:16AM +0100, Stefano Brivio wrote: On Tue, 18 Dec 2007 22:45:10 -0800 Greg KH [EMAIL PROTECTED] wrote: On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: here comes an implementation of debugfs_create_s{8,16,32,64} which avoids code

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-18 Thread Greg KH
On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: > Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to > remove > a cast in libfs. > > Cc: Johannes Berg <[EMAIL PROTECTED]> > To: Greg Kroah-Hartman <[EMAIL PROTECTED]> > Signed-off-by: Stefano Brivio <[EMAIL

[PATCH v3 7/8] debugfs: allow access to signed values

2007-12-18 Thread Stefano Brivio
Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg <[EMAIL PROTECTED]> To: Greg Kroah-Hartman <[EMAIL PROTECTED]> Signed-off-by: Stefano Brivio <[EMAIL PROTECTED]> --- Greg, here comes an implementation of

[PATCH v3 7/8] debugfs: allow access to signed values

2007-12-18 Thread Stefano Brivio
Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg [EMAIL PROTECTED] To: Greg Kroah-Hartman [EMAIL PROTECTED] Signed-off-by: Stefano Brivio [EMAIL PROTECTED] --- Greg, here comes an implementation of debugfs_create_s{8,16,32,64}

Re: [PATCH v3 7/8] debugfs: allow access to signed values

2007-12-18 Thread Greg KH
On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote: Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg [EMAIL PROTECTED] To: Greg Kroah-Hartman [EMAIL PROTECTED] Signed-off-by: Stefano Brivio [EMAIL PROTECTED]