Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-18 Thread Ricardo Ribalda Delgado
Hi Hans On Mon, Jul 18, 2016 at 10:51 AM, Hans Verkuil wrote: >> + int y, cb, cr; >> + bool ycbbr_valid = false; > > I guess you mean ycbcr_valid? Yes, I think the medical term is Saturday dyslexia :) It is fixed on the next version. Thanks!

Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-18 Thread Ricardo Ribalda Delgado
Hi Hans On Mon, Jul 18, 2016 at 10:51 AM, Hans Verkuil wrote: >> + int y, cb, cr; >> + bool ycbbr_valid = false; > > I guess you mean ycbcr_valid? Yes, I think the medical term is Saturday dyslexia :) It is fixed on the next version. Thanks!

Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-18 Thread Hans Verkuil
On 07/16/2016 12:41 PM, Ricardo Ribalda Delgado wrote: > precalculate_color() had a optimization that avoided duplicated > conversion for YUV formats. This optimization did not take into > consideration YUV444, YUV555, YUV565 or limited range quantization. > > This patch keeps the optimization,

Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-18 Thread Hans Verkuil
On 07/16/2016 12:41 PM, Ricardo Ribalda Delgado wrote: > precalculate_color() had a optimization that avoided duplicated > conversion for YUV formats. This optimization did not take into > consideration YUV444, YUV555, YUV565 or limited range quantization. > > This patch keeps the optimization,

[PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-16 Thread Ricardo Ribalda Delgado
precalculate_color() had a optimization that avoided duplicated conversion for YUV formats. This optimization did not take into consideration YUV444, YUV555, YUV565 or limited range quantization. This patch keeps the optimization, but fixes the wrong handling. Signed-off-by: Ricardo Ribalda

[PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

2016-07-16 Thread Ricardo Ribalda Delgado
precalculate_color() had a optimization that avoided duplicated conversion for YUV formats. This optimization did not take into consideration YUV444, YUV555, YUV565 or limited range quantization. This patch keeps the optimization, but fixes the wrong handling. Signed-off-by: Ricardo Ribalda