Re: [PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-16 Thread Andrii Nakryiko
On Mon, Sep 16, 2019 at 2:35 PM Andreas Schwab wrote: > > On Sep 16 2019, Andrii Nakryiko wrote: > > > On Mon, Sep 16, 2019 at 3:59 AM Ivan Khoronzhuk > > wrote: > >> > >> echo should be replaced with echo -e to handle '\n' correctly, but > >> instead, replace it with printf as some systems

Re: [PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-16 Thread Andreas Schwab
On Sep 16 2019, Andrii Nakryiko wrote: > On Mon, Sep 16, 2019 at 3:59 AM Ivan Khoronzhuk > wrote: >> >> echo should be replaced with echo -e to handle '\n' correctly, but >> instead, replace it with printf as some systems can't handle echo -e. >> >> Signed-off-by: Ivan Khoronzhuk >> --- >>

Re: [PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-16 Thread Ivan Khoronzhuk
On Mon, Sep 16, 2019 at 01:13:23PM -0700, Andrii Nakryiko wrote: On Mon, Sep 16, 2019 at 3:59 AM Ivan Khoronzhuk wrote: echo should be replaced with echo -e to handle '\n' correctly, but instead, replace it with printf as some systems can't handle echo -e. Signed-off-by: Ivan Khoronzhuk ---

Re: [PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-16 Thread Andrii Nakryiko
On Mon, Sep 16, 2019 at 3:59 AM Ivan Khoronzhuk wrote: > > echo should be replaced with echo -e to handle '\n' correctly, but > instead, replace it with printf as some systems can't handle echo -e. > > Signed-off-by: Ivan Khoronzhuk > --- > samples/bpf/Makefile | 2 +- > 1 file changed, 1

[PATCH v3 bpf-next 01/14] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-16 Thread Ivan Khoronzhuk
echo should be replaced with echo -e to handle '\n' correctly, but instead, replace it with printf as some systems can't handle echo -e. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile