Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-23 Thread harinath Nampally
> Am 23.08.2017 02:29 schrieb Harinath Nampally: > If rising: use transient OR ff_mt device-dependent like before. But now save > it in a simple flag, > whether transient registers are available. > Ok, is it good idea to add the flag to struct mma_chip_info like below? > * @mma_scales:

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-23 Thread harinath Nampally
> Am 23.08.2017 02:29 schrieb Harinath Nampally: > If rising: use transient OR ff_mt device-dependent like before. But now save > it in a simple flag, > whether transient registers are available. > Ok, is it good idea to add the flag to struct mma_chip_info like below? > * @mma_scales:

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-22 Thread Martin Kepplinger
Am 23.08.2017 02:29 schrieb Harinath Nampally: If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-22 Thread Martin Kepplinger
Am 23.08.2017 02:29 schrieb Harinath Nampally: If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-22 Thread Harinath Nampally
If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:scale factors for converting register

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-22 Thread Harinath Nampally
If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:scale factors for converting register

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-21 Thread Martin Kepplinger
Thanks. I may have missed something, but I'm concerned about only one thing: devices without transient event registers. See my comments below. Am 20.08.2017 18:06 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-21 Thread Martin Kepplinger
Thanks. I may have missed something, but I'm concerned about only one thing: devices without transient event registers. See my comments below. Am 20.08.2017 18:06 schrieb Harinath Nampally: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost

[PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-20 Thread Harinath Nampally
This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can be supported by this driver at any given

[PATCH v4] iio: accel: mma8452: improvements to handle multiple events

2017-08-20 Thread Harinath Nampally
This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can be supported by this driver at any given