Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Wed, Oct 11, 2017 at 10:43:24PM +0200, Henrik Rydberg wrote: > > > > , but I'd go for fixing the documentation. And re-reading it, it's not > > > > clear that the doc tells us to have [0,90]. It mentions negative values > > > > and out of ranges too, so we might just as well simply clarify

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Wed, Oct 11, 2017 at 10:43:24PM +0200, Henrik Rydberg wrote: > > > > , but I'd go for fixing the documentation. And re-reading it, it's not > > > > clear that the doc tells us to have [0,90]. It mentions negative values > > > > and out of ranges too, so we might just as well simply clarify

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

> > > , but I'd go for fixing the documentation. And re-reading it, it's not > > > clear that the doc tells us to have [0,90]. It mentions negative values > > > and out of ranges too, so we might just as well simply clarify that we > > > rather have [-90,90], with 0 being "north". > > > > ...

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

> > > , but I'd go for fixing the documentation. And re-reading it, it's not > > > clear that the doc tells us to have [0,90]. It mentions negative values > > > and out of ranges too, so we might just as well simply clarify that we > > > rather have [-90,90], with 0 being "north". > > > > ...

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 11 2017 or thereabouts, Jiri Kosina wrote: > On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > > > I am not sure if libinput even uses ABS_MT_ORIENTATION > > I don't think it does, so that should be okay. However ... I had a meeting this Peter at noon today. The summary is that libinput

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 11 2017 or thereabouts, Jiri Kosina wrote: > On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > > > I am not sure if libinput even uses ABS_MT_ORIENTATION > > I don't think it does, so that should be okay. However ... I had a meeting this Peter at noon today. The summary is that libinput

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > I am not sure if libinput even uses ABS_MT_ORIENTATION I don't think it does, so that should be okay. However ... > , but I'd go for fixing the documentation. And re-reading it, it's not > clear that the doc tells us to have [0,90]. It mentions

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > I am not sure if libinput even uses ABS_MT_ORIENTATION I don't think it does, so that should be okay. However ... > , but I'd go for fixing the documentation. And re-reading it, it's not > clear that the doc tells us to have [0,90]. It mentions

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Dmitry Torokhov wrote: > On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > > Hi Wei-Ning, > > > >> The current hid-multitouch driver only allow the report of two > >> orientations, vertical and horizontal. We use the Azimuth orientation >

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Dmitry Torokhov wrote: > On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > > Hi Wei-Ning, > > > >> The current hid-multitouch driver only allow the report of two > >> orientations, vertical and horizontal. We use the Azimuth orientation > >> usage 0x3F under

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > Hi Wei-Ning, > >> The current hid-multitouch driver only allow the report of two >> orientations, vertical and horizontal. We use the Azimuth orientation >> usage 0x3F under the Digitizer usage page to report

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > Hi Wei-Ning, > >> The current hid-multitouch driver only allow the report of two >> orientations, vertical and horizontal. We use the Azimuth orientation >> usage 0x3F under the Digitizer usage page to report orientation if the >> device

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Wei-Ning Huang wrote: > From: Wei-Ning Huang > > The current hid-multitouch driver only allow the report of two > orientations, vertical and horizontal. We use the Azimuth orientation > usage 0x3F under the Digitizer usage page to report

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Wei-Ning Huang wrote: > From: Wei-Ning Huang > > The current hid-multitouch driver only allow the report of two > orientations, vertical and horizontal. We use the Azimuth orientation > usage 0x3F under the Digitizer usage page to report orientation if the > device

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

Hi Wei-Ning, > The current hid-multitouch driver only allow the report of two > orientations, vertical and horizontal. We use the Azimuth orientation > usage 0x3F under the Digitizer usage page to report orientation if the > device supports it. > > Changelog: > v1 -> v2: >- Fix commit

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

Hi Wei-Ning, > The current hid-multitouch driver only allow the report of two > orientations, vertical and horizontal. We use the Azimuth orientation > usage 0x3F under the Digitizer usage page to report orientation if the > device supports it. > > Changelog: > v1 -> v2: >- Fix commit

[PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

From: Wei-Ning Huang The current hid-multitouch driver only allow the report of two orientations, vertical and horizontal. We use the Azimuth orientation usage 0x3F under the Digitizer usage page to report orientation if the device supports it. Changelog: v1 -> v2: -

[PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

From: Wei-Ning Huang The current hid-multitouch driver only allow the report of two orientations, vertical and horizontal. We use the Azimuth orientation usage 0x3F under the Digitizer usage page to report orientation if the device supports it. Changelog: v1 -> v2: - Fix commit message.