Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-11-18 Thread David Gibson
On Mon, Oct 29, 2018 at 03:32:34PM -0600, Alex Williamson wrote: > On Mon, 29 Oct 2018 13:56:54 -0500 > Wenwen Wang wrote: > > > Hello, > > > > Could you please apply this patch? Thanks! > > I'd like to see testing and/or review from David or Alexey since I also > don't have an environment for

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-11-18 Thread David Gibson
On Mon, Oct 29, 2018 at 03:32:34PM -0600, Alex Williamson wrote: > On Mon, 29 Oct 2018 13:56:54 -0500 > Wenwen Wang wrote: > > > Hello, > > > > Could you please apply this patch? Thanks! > > I'd like to see testing and/or review from David or Alexey since I also > don't have an environment for

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Wenwen Wang
On Mon, Oct 29, 2018 at 4:32 PM Alex Williamson wrote: > > On Mon, 29 Oct 2018 13:56:54 -0500 > Wenwen Wang wrote: > > > Hello, > > > > Could you please apply this patch? Thanks! > > I'd like to see testing and/or review from David or Alexey since I also > don't have an environment for

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Wenwen Wang
On Mon, Oct 29, 2018 at 4:32 PM Alex Williamson wrote: > > On Mon, 29 Oct 2018 13:56:54 -0500 > Wenwen Wang wrote: > > > Hello, > > > > Could you please apply this patch? Thanks! > > I'd like to see testing and/or review from David or Alexey since I also > don't have an environment for

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Alex Williamson
On Mon, 29 Oct 2018 13:56:54 -0500 Wenwen Wang wrote: > Hello, > > Could you please apply this patch? Thanks! I'd like to see testing and/or review from David or Alexey since I also don't have an environment for spapr/eeh. We're already late into the v4.20 merge window so this is probably

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Alex Williamson
On Mon, 29 Oct 2018 13:56:54 -0500 Wenwen Wang wrote: > Hello, > > Could you please apply this patch? Thanks! I'd like to see testing and/or review from David or Alexey since I also don't have an environment for spapr/eeh. We're already late into the v4.20 merge window so this is probably

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Wenwen Wang
Hello, Could you please apply this patch? Thanks! Wenwen On Wed, Oct 17, 2018 at 2:18 PM Wenwen Wang wrote: > > In vfio_spapr_iommu_eeh_ioctl(), if the ioctl command is VFIO_EEH_PE_OP, > the user-space buffer 'arg' is copied to the kernel object 'op' and the > 'argsz' and 'flags' fields of

Re: [PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-29 Thread Wenwen Wang
Hello, Could you please apply this patch? Thanks! Wenwen On Wed, Oct 17, 2018 at 2:18 PM Wenwen Wang wrote: > > In vfio_spapr_iommu_eeh_ioctl(), if the ioctl command is VFIO_EEH_PE_OP, > the user-space buffer 'arg' is copied to the kernel object 'op' and the > 'argsz' and 'flags' fields of

[PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-17 Thread Wenwen Wang
In vfio_spapr_iommu_eeh_ioctl(), if the ioctl command is VFIO_EEH_PE_OP, the user-space buffer 'arg' is copied to the kernel object 'op' and the 'argsz' and 'flags' fields of 'op' are checked. If the check fails, an error code EINVAL is returned. Otherwise, 'op.op' is further checked through a

[PATCH v4] drivers/vfio: Fix a redundant copy bug

2018-10-17 Thread Wenwen Wang
In vfio_spapr_iommu_eeh_ioctl(), if the ioctl command is VFIO_EEH_PE_OP, the user-space buffer 'arg' is copied to the kernel object 'op' and the 'argsz' and 'flags' fields of 'op' are checked. If the check fails, an error code EINVAL is returned. Otherwise, 'op.op' is further checked through a