Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread David Miller
From: Herbert Xu Date: Mon, 21 Sep 2015 14:06:36 +0800 > On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: >> From: Herbert Xu >> Date: Fri, 18 Sep 2015 19:16:50 +0800 >> >> > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: >> > Reset portid after netlink_insert

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread Herbert Xu
On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: > From: Herbert Xu > Date: Fri, 18 Sep 2015 19:16:50 +0800 > > > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > > Reset portid after netlink_insert failure") introduced a race > > condition where if two threads try

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread David Miller
From: Herbert Xu Date: Mon, 21 Sep 2015 14:06:36 +0800 > On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: >> From: Herbert Xu >> Date: Fri, 18 Sep 2015 19:16:50 +0800 >> >> > The commit

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-21 Thread Herbert Xu
On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote: > From: Herbert Xu > Date: Fri, 18 Sep 2015 19:16:50 +0800 > > > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > > Reset portid after netlink_insert failure") introduced a race > >

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-20 Thread David Miller
From: Herbert Xu Date: Fri, 18 Sep 2015 19:16:50 +0800 > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > Reset portid after netlink_insert failure") introduced a race > condition where if two threads try to autobind the same socket > one of them may end up with a zero port ID.

Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-20 Thread David Miller
From: Herbert Xu Date: Fri, 18 Sep 2015 19:16:50 +0800 > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > Reset portid after netlink_insert failure") introduced a race > condition where if two threads try to autobind the same socket > one of them may

[PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-18 Thread Herbert Xu
On Fri, Sep 18, 2015 at 02:36:09PM +0800, Herbert Xu wrote: > > But yes there are ordering issues here so I've decided to make > rhashtable use a new field for its hash instead. > > Note that I've dropped the acks as this patch is now substantially > different. v3 doesn't apply to the current

[PATCH v4] netlink: Fix autobind race condition that leads to zero port ID

2015-09-18 Thread Herbert Xu
On Fri, Sep 18, 2015 at 02:36:09PM +0800, Herbert Xu wrote: > > But yes there are ordering issues here so I've decided to make > rhashtable use a new field for its hash instead. > > Note that I've dropped the acks as this patch is now substantially > different. v3 doesn't apply to the current