Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 07:28 PM, FanWu wrote: > On 06/04/2014 12:49 AM, Stephen Warren wrote: >> On 06/03/2014 01:37 AM, f...@marvell.com wrote: >>> From: Fan Wu >>> >>> What the patch did: >>> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in >>> each time of >>>calling

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/04/2014 12:49 AM, Stephen Warren wrote: On 06/03/2014 01:37 AM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 01:37 AM, f...@marvell.com wrote: > From: Fan Wu > > What the patch did: > 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time > of > calling pinctrl_select_state > 2.Remove the HW disable operation in in pinmux_disable_setting function. > 3.Remove the

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 01:48 AM, FanWu wrote: > On 06/03/2014 03:37 PM, f...@marvell.com wrote: >> From: Fan Wu >> >> What the patch did: >> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in >> each time of >>calling pinctrl_select_state >> 2.Remove the HW disable operation in in

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/03/2014 03:37 PM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. 3.Remove the disable ops in

[PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread fwu
From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. 3.Remove the disable ops in struct pinmux_ops The reason why to do this is

[PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread fwu
From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. 3.Remove the disable ops in struct pinmux_ops The reason why

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/03/2014 03:37 PM, f...@marvell.com wrote: From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. 3.Remove the

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 01:48 AM, FanWu wrote: On 06/03/2014 03:37 PM, f...@marvell.com wrote: From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 01:37 AM, f...@marvell.com wrote: From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function.

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/04/2014 12:49 AM, Stephen Warren wrote: On 06/03/2014 01:37 AM, f...@marvell.com wrote: From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread Stephen Warren
On 06/03/2014 07:28 PM, FanWu wrote: On 06/04/2014 12:49 AM, Stephen Warren wrote: On 06/03/2014 01:37 AM, f...@marvell.com wrote: From: Fan Wu f...@marvell.com What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling