Re: [PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

2019-09-24 Thread Daniel Campello
Thanks. I sent v5 with the corrections

Re: [PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

2019-09-23 Thread Benson Leung
Hi Daniel, Thanks for sending this. On Wed, Sep 18, 2019 at 02:43:16PM -0600, Daniel Campello wrote: > This change introduces a new debugfs file 'test_event' that when written > to causes the EC to generate a test event. Please mention that this adds a second sub cmd for the test event, and

Re: [PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

2019-09-18 Thread Nick Crews
Assuming that the Kbuild bot doesn't get mad about the format string now, LGTM. Thanks Daniel! Reviewed-by: Nick Crews On Wed, Sep 18, 2019 at 2:43 PM Daniel Campello wrote: > > This change introduces a new debugfs file 'test_event' that when written > to causes the EC to generate a test

[PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

2019-09-18 Thread Daniel Campello
This change introduces a new debugfs file 'test_event' that when written to causes the EC to generate a test event. Signed-off-by: Daniel Campello --- Changes for v2: - Cleaned up and added comments. - Renamed and updated function signature from write_to_mailbox to send_ec_cmd. Changes