Re: [PATCH v4] tools/x86: Add a kcpuid tool to show raw CPU features

2021-01-19 Thread Borislav Petkov
On Tue, Jan 19, 2021 at 08:56:39PM +0800, Feng Tang wrote: > Right! So this is better? > /* Skip line parsing for non-existing indexes */ Of course! Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v4] tools/x86: Add a kcpuid tool to show raw CPU features

2021-01-19 Thread Feng Tang
On Tue, Jan 19, 2021 at 10:11:16AM +0100, Borislav Petkov wrote: > On Tue, Jan 19, 2021 at 01:19:42PM +0800, Feng Tang wrote: > > Sorry, after testing on more platforms, the following is needed to fix > > a potential array overflow ((a full patch with fix is also attached) > > > > diff --git

Re: [PATCH v4] tools/x86: Add a kcpuid tool to show raw CPU features

2021-01-19 Thread Borislav Petkov
On Tue, Jan 19, 2021 at 01:19:42PM +0800, Feng Tang wrote: > Sorry, after testing on more platforms, the following is needed to fix > a potential array overflow ((a full patch with fix is also attached) > > diff --git a/tools/arch/x86/kcpuid/kcpuid.c b/tools/arch/x86/kcpuid/kcpuid.c > index

Re: [PATCH v4] tools/x86: Add a kcpuid tool to show raw CPU features

2021-01-18 Thread Feng Tang
Sorry, after testing on more platforms, the following is needed to fix a potential array overflow ((a full patch with fix is also attached) diff --git a/tools/arch/x86/kcpuid/kcpuid.c b/tools/arch/x86/kcpuid/kcpuid.c index 3ea607b..bf68335 100644 --- a/tools/arch/x86/kcpuid/kcpuid.c +++

[PATCH v4] tools/x86: Add a kcpuid tool to show raw CPU features

2021-01-17 Thread Feng Tang
End users frequently want to know what features their processor supports, independent of what the kernel supports. /proc/cpuinfo is great. It is omnipresent and since it is provided by the kernel it is always as up to date as the kernel. But, it could be ambiguous about processor features which