Re: [PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Oscar Salvador
On Mon, Jul 09, 2018 at 02:29:28PM -0700, Andrew Morton wrote: > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin > wrote: > > > In sparse_init() we allocate two large buffers to temporary hold usemap and > > memmap for the whole machine. However, we can avoid doing that if we > > changed spars

Re: [PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Andrew Morton
On Tue, 10 Jul 2018 07:56:04 +0800 Baoquan He wrote: > Hi Andrew, > > On 07/09/18 at 02:29pm, Andrew Morton wrote: > > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin > > wrote: > > > For the ease of review, I split this work so the first patch only adds new > > > interfaces, the second patc

Re: [PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Baoquan He
Hi Andrew, On 07/09/18 at 02:29pm, Andrew Morton wrote: > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin > wrote: > > For the ease of review, I split this work so the first patch only adds new > > interfaces, the second patch enables them, and removes the old ones. > > This clashes pretty si

Re: [PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Pavel Tatashin
On Mon, Jul 9, 2018 at 5:29 PM Andrew Morton wrote: > > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin > wrote: > > > In sparse_init() we allocate two large buffers to temporary hold usemap and > > memmap for the whole machine. However, we can avoid doing that if we > > changed sparse_init()

Re: [PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Andrew Morton
On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin wrote: > In sparse_init() we allocate two large buffers to temporary hold usemap and > memmap for the whole machine. However, we can avoid doing that if we > changed sparse_init() to operated on per-node bases instead of doing it on > the whole m

[PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Pavel Tatashin
Changelog: v4 - v3 - Addressed comments from Dave Hansen v3 - v1 - Fixed two issues found by Baoquan He v1 - v2 - Addressed comments from Oscar Salvador In sparse_init() we allocate two large buffers to temporary hold usemap and memmap for the whole machine. However, we can