Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-28 Thread Rafael J. Wysocki
On Mon, Sep 28, 2015 at 10:17 PM, Al Stone wrote: > On 09/25/2015 05:29 PM, Rafael J. Wysocki wrote: >> On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: [cut] >> In particular, I'm not sure if we really need to return >> -EINVAL from acpi_parse_entries_array() when we find a bad

Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-28 Thread Al Stone
On 09/25/2015 05:29 PM, Rafael J. Wysocki wrote: > On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: >> Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity >> check on the various subtables that are defined for the MADT. The check >> compares the size of the subtable

Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-28 Thread Al Stone
On 09/25/2015 05:29 PM, Rafael J. Wysocki wrote: > On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: >> Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity >> check on the various subtables that are defined for the MADT. The check >> compares the size of the subtable

Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-28 Thread Rafael J. Wysocki
On Mon, Sep 28, 2015 at 10:17 PM, Al Stone wrote: > On 09/25/2015 05:29 PM, Rafael J. Wysocki wrote: >> On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: [cut] >> In particular, I'm not sure if we really need to return >> -EINVAL from acpi_parse_entries_array() when

Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-25 Thread Rafael J. Wysocki
On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: > Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity > check on the various subtables that are defined for the MADT. The check > compares the size of the subtable data structure as defined by ACPICA to > the length

Re: [PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-25 Thread Rafael J. Wysocki
On Wednesday, September 16, 2015 05:26:40 PM Al Stone wrote: > Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity > check on the various subtables that are defined for the MADT. The check > compares the size of the subtable data structure as defined by ACPICA to > the length

[PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-16 Thread Al Stone
Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity check on the various subtables that are defined for the MADT. The check compares the size of the subtable data structure as defined by ACPICA to the length entry in the subtable. If they are not the same, the assumption is

[PATCH v4 0/5] Provide better MADT subtable sanity checks

2015-09-16 Thread Al Stone
Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity check on the various subtables that are defined for the MADT. The check compares the size of the subtable data structure as defined by ACPICA to the length entry in the subtable. If they are not the same, the assumption is