Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2021-02-23 Thread Matthew Wilcox
On Tue, Feb 23, 2021 at 02:58:36PM -0800, Andrew Morton wrote: > Do you feel this patchset is ready to merge up? I think so. > https://lore.kernel.org/linux-mm/f6914405b49d9...@google.com/ > was addressed by 0060ef3b4e6dd ("mm: support THPs in > zero_user_segments"), yes? Correct.

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2021-02-23 Thread Andrew Morton
Do you feel this patchset is ready to merge up? https://lore.kernel.org/linux-mm/f6914405b49d9...@google.com/ was addressed by 0060ef3b4e6dd ("mm: support THPs in zero_user_segments"), yes? "mm/truncate,shmem: Handle truncates that split THPs" and "mm/filemap: Return only head pages

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-12-03 Thread Hugh Dickins
On Thu, 3 Dec 2020, Qian Cai wrote: > On Thu, 2020-12-03 at 18:27 +0100, Marek Szyprowski wrote: > > On 03.12.2020 16:46, Marek Szyprowski wrote: > > > On 25.11.2020 03:32, Matthew Wilcox wrote: > > > > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > > > > On Tue, Nov 17, 2020

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-12-03 Thread Hugh Dickins
On Thu, 3 Dec 2020, Marek Szyprowski wrote: > On 03.12.2020 16:46, Marek Szyprowski wrote: > > On 25.11.2020 03:32, Matthew Wilcox wrote: > >> On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > >>> On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > I find both of

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-12-03 Thread Qian Cai
On Thu, 2020-12-03 at 18:27 +0100, Marek Szyprowski wrote: > Hi > > On 03.12.2020 16:46, Marek Szyprowski wrote: > > On 25.11.2020 03:32, Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > > > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-12-03 Thread Marek Szyprowski
Hi On 03.12.2020 16:46, Marek Szyprowski wrote: > On 25.11.2020 03:32, Matthew Wilcox wrote: >> On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: >>> On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: I find both of these functions exceptionally confusing.  Does

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-12-03 Thread Marek Szyprowski
Hi On 25.11.2020 03:32, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: >> On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: >>> I find both of these functions exceptionally confusing. Does this >>> make it easier to understand? >> Never

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-30 Thread Hugh Dickins
On Mon, 30 Nov 2020, Hugh Dickins wrote: > On Thu, 26 Nov 2020, Matthew Wilcox wrote: > > On Thu, Nov 26, 2020 at 11:24:59AM -0800, Hugh Dickins wrote: > > > > > But right now it's the right fix that's important: ack to yours below. > > > > > > I've not yet worked out the other issues I saw:

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-30 Thread Hugh Dickins
On Thu, 26 Nov 2020, Matthew Wilcox wrote: > On Thu, Nov 26, 2020 at 11:24:59AM -0800, Hugh Dickins wrote: > > > But right now it's the right fix that's important: ack to yours below. > > > > I've not yet worked out the other issues I saw: will report when I have. > > Rebooted this laptop,

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-26 Thread Matthew Wilcox
On Thu, Nov 26, 2020 at 11:24:59AM -0800, Hugh Dickins wrote: > On Thu, 26 Nov 2020, Matthew Wilcox wrote: > > On Wed, Nov 25, 2020 at 04:11:57PM -0800, Hugh Dickins wrote: > > > > + index = > > > > truncate_inode_partial_page(mapping, > > > > +

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-26 Thread Hugh Dickins
On Thu, 26 Nov 2020, Matthew Wilcox wrote: > On Wed, Nov 25, 2020 at 04:11:57PM -0800, Hugh Dickins wrote: > > > + index = > > > truncate_inode_partial_page(mapping, > > > + page, lstart, lend); > > > +

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-26 Thread Matthew Wilcox
On Wed, Nov 25, 2020 at 04:11:57PM -0800, Hugh Dickins wrote: > The little fix definitely needed was shown by generic/083: each > fsstress waiting for page lock, happens even without forcing huge > pages. See below... Huh ... I need to look into why my xfstests run is skipping generic/083: 0006

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-25 Thread Hugh Dickins
On Wed, Nov 25, 2020 at 3:09 PM Andrew Morton wrote: > > On Wed, 25 Nov 2020 02:32:34 + Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > > > > I find both of these functions

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-25 Thread Andrew Morton
On Wed, 25 Nov 2020 02:32:34 + Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > > > I find both of these functions exceptionally confusing. Does this > > > make it easier to

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-24 Thread Hugh Dickins
On Tue, 24 Nov 2020, Hugh Dickins wrote: > On Wed, 25 Nov 2020, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > > > > I find both of these functions exceptionally confusing. Does this

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-24 Thread Hugh Dickins
On Wed, 25 Nov 2020, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > > > I find both of these functions exceptionally confusing. Does this > > > make it easier to understand? > > > >

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-24 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > > I find both of these functions exceptionally confusing. Does this > > make it easier to understand? > > Never mind, this is buggy. I'll send something better

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-17 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > I find both of these functions exceptionally confusing. Does this > make it easier to understand? Never mind, this is buggy. I'll send something better tomorrow.

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-17 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 08:26:03AM -0800, Hugh Dickins wrote: > On Tue, 17 Nov 2020, Matthew Wilcox wrote: > > On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > > > Fix to [PATCH v4 15/16] mm/truncate,shmem: Handle truncates that split > > > THPs. > > > One machine ran fine,

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-17 Thread Hugh Dickins
On Tue, 17 Nov 2020, Matthew Wilcox wrote: > On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > > Fix to [PATCH v4 15/16] mm/truncate,shmem: Handle truncates that split THPs. > > One machine ran fine, swapping and building in ext4 on loop0 on huge tmpfs; > > one machine got occasional

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-17 Thread Matthew Wilcox
On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > Fix to [PATCH v4 15/16] mm/truncate,shmem: Handle truncates that split THPs. > One machine ran fine, swapping and building in ext4 on loop0 on huge tmpfs; > one machine got occasional pages of zeros in its .os; one machine couldn't >

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-16 Thread Hugh Dickins
On Mon, 16 Nov 2020, Matthew Wilcox wrote: > On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > > On Thu, 12 Nov 2020, Matthew Wilcox (Oracle) wrote: > > > > > This THP prep patchset changes several page cache iteration APIs to only > > > return head pages. > > > > > > - It's only

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-16 Thread Matthew Wilcox
On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > On Thu, 12 Nov 2020, Matthew Wilcox (Oracle) wrote: > > > This THP prep patchset changes several page cache iteration APIs to only > > return head pages. > > > > - It's only possible to tag head pages in the page cache, so only > >

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-16 Thread Hugh Dickins
On Thu, 12 Nov 2020, Matthew Wilcox (Oracle) wrote: > This THP prep patchset changes several page cache iteration APIs to only > return head pages. > > - It's only possible to tag head pages in the page cache, so only >return head pages, not all their subpages. > - Factor a lot of common

[PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-12 Thread Matthew Wilcox (Oracle)
This THP prep patchset changes several page cache iteration APIs to only return head pages. - It's only possible to tag head pages in the page cache, so only return head pages, not all their subpages. - Factor a lot of common code out of the various batch lookup routines - Add