Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-30 Thread Sebastian Hesselbarth
On 30.04.2015 16:31, Antoine Tenart wrote: On Thu, Apr 16, 2015 at 01:59:32PM -0300, Ezequiel Garcia wrote: On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: All we need is a function to convert sdr_timings to sane driver timings. And we really need to split this patch into tiny pieces

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-30 Thread Antoine Tenart
On Thu, Apr 16, 2015 at 01:59:32PM -0300, Ezequiel Garcia wrote: > On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: > > > All we need is a function to convert sdr_timings to sane driver > > timings. And we really need to split this patch into tiny pieces > > otherwise it is not reviewable -

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-30 Thread Antoine Tenart
On Thu, Apr 16, 2015 at 01:59:32PM -0300, Ezequiel Garcia wrote: On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: All we need is a function to convert sdr_timings to sane driver timings. And we really need to split this patch into tiny pieces otherwise it is not reviewable - or at

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-30 Thread Sebastian Hesselbarth
On 30.04.2015 16:31, Antoine Tenart wrote: On Thu, Apr 16, 2015 at 01:59:32PM -0300, Ezequiel Garcia wrote: On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: All we need is a function to convert sdr_timings to sane driver timings. And we really need to split this patch into tiny pieces

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-17 Thread Robert Jarzmik
Ezequiel Garcia writes: >> Also, as soon as Robert moves pxa3xx boards fully to DT, we'll loose >> the pdata timings option above. *sigh* >> > Well, such move would include proper timing DT properties for non-ONFI > devices. I will move several boards to DT, including several pxa3x boards, but

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-17 Thread Robert Jarzmik
Ezequiel Garcia ezequiel.gar...@free-electrons.com writes: Also, as soon as Robert moves pxa3xx boards fully to DT, we'll loose the pdata timings option above. *sigh* Well, such move would include proper timing DT properties for non-ONFI devices. I will move several boards to DT, including

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Ezequiel Garcia
On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: > On 04/16/2015 03:10 PM, Ezequiel Garcia wrote: >> On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: >>> On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Sebastian Hesselbarth
On 04/16/2015 03:10 PM, Ezequiel Garcia wrote: On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Ezequiel Garcia
On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: > On 15.04.2015 19:24, Antoine Tenart wrote: >> Rework the pxa3xx_nand driver to allow using functions exported by the >> nand framework to detect the flash and to configure the timings. >> >> Because this driver supports some non-ONFI devices,

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Ezequiel Garcia
On 04/16/2015 10:41 AM, Sebastian Hesselbarth wrote: On 04/16/2015 03:10 PM, Ezequiel Garcia wrote: On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Ezequiel Garcia
On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this driver supports some non-ONFI devices, we also

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-16 Thread Sebastian Hesselbarth
On 04/16/2015 03:10 PM, Ezequiel Garcia wrote: On 04/15/2015 04:11 PM, Sebastian Hesselbarth wrote: On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-15 Thread Sebastian Hesselbarth
On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this driver supports some non-ONFI devices, we also keep the custom timing setup of this driver so these

[PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-15 Thread Antoine Tenart
Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this driver supports some non-ONFI devices, we also keep the custom timing setup of this driver so these devices won't break. Signed-off-by: Antoine

[PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-15 Thread Antoine Tenart
Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this driver supports some non-ONFI devices, we also keep the custom timing setup of this driver so these devices won't break. Signed-off-by: Antoine

Re: [PATCH v4 04/10] mtd: pxa3xx_nand: rework flash detection and timing setup

2015-04-15 Thread Sebastian Hesselbarth
On 15.04.2015 19:24, Antoine Tenart wrote: Rework the pxa3xx_nand driver to allow using functions exported by the nand framework to detect the flash and to configure the timings. Because this driver supports some non-ONFI devices, we also keep the custom timing setup of this driver so these