Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-09 Thread Joonsoo Kim
2020년 7월 9일 (목) 오후 3:43, Michal Hocko 님이 작성: > > On Wed 08-07-20 09:41:06, Michal Hocko wrote: > > On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: > > > On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > > > > On 7/7/20 9:44 AM, js1...@gmail.com wrote: > > > > > From: Joonsoo Kim > >

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-09 Thread Michal Hocko
On Wed 08-07-20 09:41:06, Michal Hocko wrote: > On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: > > On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > > > On 7/7/20 9:44 AM, js1...@gmail.com wrote: > > > > From: Joonsoo Kim > > > > > > > > new_non_cma_page() in gup.c which try to

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Mike Kravetz
On 7/8/20 12:16 AM, Joonsoo Kim wrote: > On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: >> On 7/7/20 9:44 AM, js1...@gmail.com wrote: >>> From: Joonsoo Kim >>> <...> >>> This patch makes the deque function on hugetlb CMA aware and skip CMA >>> pages if newly added skip_cma

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Michal Hocko
On Wed 08-07-20 16:27:16, Aneesh Kumar K.V wrote: > Vlastimil Babka writes: > > > On 7/8/20 9:41 AM, Michal Hocko wrote: > >> On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: > >>> On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > >>> > >>> Simply, I call

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Aneesh Kumar K.V
Vlastimil Babka writes: > On 7/8/20 9:41 AM, Michal Hocko wrote: >> On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: >>> On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: >>> >>> Simply, I call memalloc_nocma_{save,restore} in new_non_cma_page(). It >>> would not cause any problem.

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Vlastimil Babka
On 7/8/20 9:41 AM, Michal Hocko wrote: > On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: >> On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: >> >> Simply, I call memalloc_nocma_{save,restore} in new_non_cma_page(). It >> would not cause any problem. > > I believe a proper fix is the

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Michal Hocko
On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: > On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > > On 7/7/20 9:44 AM, js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > > > new_non_cma_page() in gup.c which try to allocate migration target page > > > requires to allocate

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Joonsoo Kim
On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > On 7/7/20 9:44 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > new_non_cma_page() in gup.c which try to allocate migration target page > > requires to allocate the new page that is not on the CMA area. > >

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Joonsoo Kim
On Tue, Jul 07, 2020 at 01:31:16PM +0200, Michal Hocko wrote: > On Tue 07-07-20 16:44:42, Joonsoo Kim wrote: > > From: Joonsoo Kim > > > > new_non_cma_page() in gup.c which try to allocate migration target page > > requires to allocate the new page that is not on the CMA area. > >

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Michal Hocko
On Tue 07-07-20 13:31:19, Michal Hocko wrote: > Btw. you are keeping his acks even > after considerable changes to patches which I am not really sure he is > ok with. I am sorry but I have missed the last email from Mike in v3. -- Michal Hocko SUSE Labs

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:42, Joonsoo Kim wrote: > From: Joonsoo Kim > > new_non_cma_page() in gup.c which try to allocate migration target page > requires to allocate the new page that is not on the CMA area. > new_non_cma_page() implements it by removing __GFP_MOVABLE flag. This way > works well

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-07 Thread Vlastimil Babka
On 7/7/20 9:44 AM, js1...@gmail.com wrote: > From: Joonsoo Kim > > new_non_cma_page() in gup.c which try to allocate migration target page > requires to allocate the new page that is not on the CMA area. > new_non_cma_page() implements it by removing __GFP_MOVABLE flag. This way > works well

[PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-07 Thread js1304
From: Joonsoo Kim new_non_cma_page() in gup.c which try to allocate migration target page requires to allocate the new page that is not on the CMA area. new_non_cma_page() implements it by removing __GFP_MOVABLE flag. This way works well for THP page or normal page but not for hugetlb page.