Re: [PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early

2021-03-02 Thread Alexandru Elisei
Hello Suzuki, On 3/2/21 10:01 AM, Suzuki K Poulose wrote: > Hi Alex > > On 3/1/21 4:32 PM, Alexandru Elisei wrote: >> Hello Suzuki, >> >> On 2/25/21 7:35 PM, Suzuki K Poulose wrote: >>> The nvhe hyp saves the SPE context, flushing any unwritten >> >> Perhaps that can be reworded to "The nVHE world

Re: [PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early

2021-03-02 Thread Suzuki K Poulose
Hi Alex On 3/1/21 4:32 PM, Alexandru Elisei wrote: Hello Suzuki, On 2/25/21 7:35 PM, Suzuki K Poulose wrote: The nvhe hyp saves the SPE context, flushing any unwritten Perhaps that can be reworded to "The nVHE world switch code saves [..]". Sure Also, according to my understanding of "c

Re: [PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early

2021-03-02 Thread Marc Zyngier
Hi Suzuki, On 2021-03-02 10:01, Suzuki K Poulose wrote: Hi Alex On 3/1/21 4:32 PM, Alexandru Elisei wrote: Hello Suzuki, On 2/25/21 7:35 PM, Suzuki K Poulose wrote: The nvhe hyp saves the SPE context, flushing any unwritten Perhaps that can be reworded to "The nVHE world switch code saves

Re: [PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early

2021-03-01 Thread Alexandru Elisei
Hello Suzuki, On 2/25/21 7:35 PM, Suzuki K Poulose wrote: > The nvhe hyp saves the SPE context, flushing any unwritten Perhaps that can be reworded to "The nVHE world switch code saves [..]". Also, according to my understanding of "context", that means saving *all* the related registers. But KVM

[PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early

2021-02-25 Thread Suzuki K Poulose
The nvhe hyp saves the SPE context, flushing any unwritten data before we switch to the guest. But this operation is performed way too late, because : - The ownership of the SPE is transferred to EL2. i.e, using EL2 translations. (MDCR_EL2_E2PB == 0) - The guest Stage1 is loaded. Thus the