Re: [PATCH v4 05/11] drm/sun4i: abstract a engine type

2017-04-20 Thread Maxime Ripard
On Tue, Apr 18, 2017 at 07:05:12PM +0800, Icenowy Zheng wrote: > >> @@ -56,7 +55,7 @@ static void sun4i_crtc_atomic_flush(struct drm_crtc > >*crtc, > >> > >>DRM_DEBUG_DRIVER("Committing plane changes\n"); > >> > >> - sun4i_backend_commit(scrtc->backend); > >> + scrtc->engine_ops->commit(s

Re: [PATCH v4 05/11] drm/sun4i: abstract a engine type

2017-04-18 Thread Icenowy Zheng
于 2017年4月18日 GMT+08:00 下午4:55:48, Maxime Ripard 写到: >Hi, > >Thanks for that rework. > >On Sun, Apr 16, 2017 at 08:08:43PM +0800, Icenowy Zheng wrote: >> As we are going to add support for the Allwinner DE2 engine in >sun4i-drm >> driver, we will finally have two types of display engines -- the

Re: [PATCH v4 05/11] drm/sun4i: abstract a engine type

2017-04-18 Thread Maxime Ripard
Hi, Thanks for that rework. On Sun, Apr 16, 2017 at 08:08:43PM +0800, Icenowy Zheng wrote: > As we are going to add support for the Allwinner DE2 engine in sun4i-drm > driver, we will finally have two types of display engines -- the DE1 > backend and the DE2 mixer. They both do some display blend

[PATCH v4 05/11] drm/sun4i: abstract a engine type

2017-04-16 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 engine in sun4i-drm driver, we will finally have two types of display engines -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "engine" here. Abstract the engi