Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-19 Thread Jessica Yu
+++ Stephen Boyd [17/04/21 18:52 -0700]: [snip] Sounds good. It means that some more ifdefs are probably required vs. making the array size be 0 when the config is disabled but that isn't a big problem for me. I'm reworking the code now and will test and then send v5 shortly. Thanks! Great,

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-17 Thread Stephen Boyd
Quoting Jessica Yu (2021-04-15 06:04:35) > +++ Stephen Boyd [09/04/21 18:52 -0700]: > >diff --git a/include/linux/module.h b/include/linux/module.h > >index 59f094fa6f74..4bf869f6c944 100644 > >--- a/include/linux/module.h > >+++ b/include/linux/module.h > >@@ -11,6 +11,7 @@ > > > > #include > >

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-15 Thread Jessica Yu
+++ Stephen Boyd [09/04/21 18:52 -0700]: Let's make kernel stacktraces easier to identify by including the build ID[1] of a module if the stacktrace is printing a symbol from a module. This makes it simpler for developers to locate a kernel module's full debuginfo for a particular stacktrace.

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-15 Thread Petr Mladek
On Tue 2021-04-13 15:57:49, Stephen Boyd wrote: > Quoting Petr Mladek (2021-04-13 08:01:14) > > On Fri 2021-04-09 18:52:52, Stephen Boyd wrote: > > > Let's make kernel stacktraces easier to identify by including the build > > > ID[1] of a module if the stacktrace is printing a symbol from a

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-13 08:01:14) > On Fri 2021-04-09 18:52:52, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for developers to locate a

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Stephen Boyd
Quoting Stephen Boyd (2021-04-13 13:10:05) > Quoting Petr Mladek (2021-04-13 08:16:20) > > On Tue 2021-04-13 13:56:31, Andy Shevchenko wrote: > > > On Mon, Apr 12, 2021 at 12:29:05PM -0700, Stephen Boyd wrote: > > > > Quoting Andy Shevchenko (2021-04-12 04:58:02) > > > > > > > > > > First of all,

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-13 08:16:20) > On Tue 2021-04-13 13:56:31, Andy Shevchenko wrote: > > On Mon, Apr 12, 2021 at 12:29:05PM -0700, Stephen Boyd wrote: > > > Quoting Andy Shevchenko (2021-04-12 04:58:02) > > > > > > > > First of all, why not static_assert() defined near to the actual

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Petr Mladek
On Tue 2021-04-13 13:56:31, Andy Shevchenko wrote: > On Mon, Apr 12, 2021 at 12:29:05PM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2021-04-12 04:58:02) > > > On Fri, Apr 09, 2021 at 06:52:52PM -0700, Stephen Boyd wrote: > > > > Let's make kernel stacktraces easier to identify by

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Petr Mladek
On Fri 2021-04-09 18:52:52, Stephen Boyd wrote: > Let's make kernel stacktraces easier to identify by including the build > ID[1] of a module if the stacktrace is printing a symbol from a module. > This makes it simpler for developers to locate a kernel module's full > debuginfo for a particular

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-13 Thread Andy Shevchenko
On Mon, Apr 12, 2021 at 12:29:05PM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2021-04-12 04:58:02) > > On Fri, Apr 09, 2021 at 06:52:52PM -0700, Stephen Boyd wrote: > > > Let's make kernel stacktraces easier to identify by including the build > > > ID[1] of a module if the stacktrace is

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-12 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-04-12 04:58:02) > On Fri, Apr 09, 2021 at 06:52:52PM -0700, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-12 Thread Andy Shevchenko
On Fri, Apr 09, 2021 at 06:52:52PM -0700, Stephen Boyd wrote: > Let's make kernel stacktraces easier to identify by including the build > ID[1] of a module if the stacktrace is printing a symbol from a module. > This makes it simpler for developers to locate a kernel module's full > debuginfo for

[PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-09 Thread Stephen Boyd
Let's make kernel stacktraces easier to identify by including the build ID[1] of a module if the stacktrace is printing a symbol from a module. This makes it simpler for developers to locate a kernel module's full debuginfo for a particular stacktrace. Combined with scripts/decode_stracktrace.sh,