Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-03 Thread David Howells
Jeff Layton wrote: > Thanks! I updated that part of the the commit log to read: > > Note that AFS has quite a different definition for this counter. AFS > only increments it on changes to the data to the data in regular files > and contents of the directories.

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-03 Thread David Howells
Jeff Layton wrote: > Thanks! I updated that part of the the commit log to read: > > Note that AFS has quite a different definition for this counter. AFS > only increments it on changes to the data to the data in regular files > and contents of the directories. Inode metadata changes

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-02 Thread Jeff Layton
On Tue, 2018-01-02 at 17:20 +, David Howells wrote: > Jeff Layton wrote: > > > Note that AFS has quite a different definition for this counter. AFS > > only increments it on changes to the data, not for the metadata. > > This also applies to AFS directories: create,

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-02 Thread Jeff Layton
On Tue, 2018-01-02 at 17:20 +, David Howells wrote: > Jeff Layton wrote: > > > Note that AFS has quite a different definition for this counter. AFS > > only increments it on changes to the data, not for the metadata. > > This also applies to AFS directories: create, mkdir, unlink, rmdir,

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-02 Thread David Howells
Jeff Layton wrote: > Note that AFS has quite a different definition for this counter. AFS > only increments it on changes to the data, not for the metadata. This also applies to AFS directories: create, mkdir, unlink, rmdir, link, symlink, rename, and mountpoint

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-02 Thread David Howells
Jeff Layton wrote: > Note that AFS has quite a different definition for this counter. AFS > only increments it on changes to the data, not for the metadata. This also applies to AFS directories: create, mkdir, unlink, rmdir, link, symlink, rename, and mountpoint creation/removal all bump the

[PATCH v4 05/19] afs: convert to new i_version API

2017-12-22 Thread Jeff Layton
From: Jeff Layton For AFS, it's generally treated as an opaque value, so we use the *_raw variants of the API here. Note that AFS has quite a different definition for this counter. AFS only increments it on changes to the data, not for the metadata. We'll need to reconcile

[PATCH v4 05/19] afs: convert to new i_version API

2017-12-22 Thread Jeff Layton
From: Jeff Layton For AFS, it's generally treated as an opaque value, so we use the *_raw variants of the API here. Note that AFS has quite a different definition for this counter. AFS only increments it on changes to the data, not for the metadata. We'll need to reconcile that somehow if we