Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-21 Thread Masahiro Yamada
Hi Joe, On Tue, Aug 20, 2019 at 1:02 AM Joe Lawrence wrote: > > On 8/19/19 3:31 AM, Miroslav Benes wrote: > > On Mon, 19 Aug 2019, Masahiro Yamada wrote: > > > >> > >> I can review this series from the build system point of view, > >> but I am not familiar enough with live-patching itself. > >>

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-20 Thread Miroslav Benes
> > How is this feature supposed to work for external modules? > > > > klp-convert receives: > > "symbols from vmlinux" + "symbols from no-klp in-tree modules" > > + "symbols from no-klp external modules" ?? > > > > I don't think that this use-case has been previously thought out (Miroslav, >

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-19 Thread Joe Lawrence
On 8/19/19 3:31 AM, Miroslav Benes wrote: On Mon, 19 Aug 2019, Masahiro Yamada wrote: I can review this series from the build system point of view, but I am not familiar enough with live-patching itself. Some possibilities: [1] Merge this series thru the live-patch tree after the

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-19 Thread Joe Lawrence
On 8/18/19 11:50 PM, Masahiro Yamada wrote: Hi Joe, On Sat, Aug 17, 2019 at 4:01 AM Joe Lawrence wrote: I didn't realize that we're supposed to be able to still build external modules after "make clean". If that's the case, then one might want to build an external klp-module after doing

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-19 Thread Miroslav Benes
On Mon, 19 Aug 2019, Masahiro Yamada wrote: > On Fri, Aug 16, 2019 at 9:43 PM Joe Lawrence wrote: > > > > On 8/16/19 4:19 AM, Miroslav Benes wrote: > > > Hi, > > > > > >> I cleaned up the build system, and pushed it based on my > > >> kbuild tree. > > >> > > >> Please see: > > >> > > >>

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-18 Thread Masahiro Yamada
Hi Joe, On Sat, Aug 17, 2019 at 4:01 AM Joe Lawrence wrote: > > On 8/16/19 8:43 AM, Joe Lawrence wrote: > > On 8/16/19 4:19 AM, Miroslav Benes wrote: > >> Hi, > >> > >>> I cleaned up the build system, and pushed it based on my > >>> kbuild tree. > >>> > >>> Please see: > >>> > >>>

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-18 Thread Masahiro Yamada
On Fri, Aug 16, 2019 at 9:43 PM Joe Lawrence wrote: > > On 8/16/19 4:19 AM, Miroslav Benes wrote: > > Hi, > > > >> I cleaned up the build system, and pushed it based on my > >> kbuild tree. > >> > >> Please see: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git >

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-16 Thread Joe Lawrence
On 8/16/19 8:43 AM, Joe Lawrence wrote: On 8/16/19 4:19 AM, Miroslav Benes wrote: Hi, I cleaned up the build system, and pushed it based on my kbuild tree. Please see: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git klp-cleanup This indeed looks much simpler and

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-16 Thread Joe Lawrence
On 8/16/19 4:19 AM, Miroslav Benes wrote: Hi, I cleaned up the build system, and pushed it based on my kbuild tree. Please see: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git klp-cleanup This indeed looks much simpler and cleaner (as far as I can judge with my

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-16 Thread Miroslav Benes
Hi, > I cleaned up the build system, and pushed it based on my > kbuild tree. > > Please see: > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > klp-cleanup This indeed looks much simpler and cleaner (as far as I can judge with my limited kbuild knowledge). We just

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-15 Thread Masahiro Yamada
Hi Joe, On Tue, Aug 13, 2019 at 12:56 AM Joe Lawrence wrote: > > On Wed, Jul 31, 2019 at 02:58:27PM +0900, Masahiro Yamada wrote: > > Hi Joe, > > > > > > On Thu, May 9, 2019 at 11:39 PM Joe Lawrence > > wrote: > > > > > > From: Miroslav Benes > > > > > > Currently, livepatch infrastructure in

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-13 Thread Miroslav Benes
On Wed, 31 Jul 2019, Masahiro Yamada wrote: > Hi Joe, > > > On Thu, May 9, 2019 at 11:39 PM Joe Lawrence wrote: > > > > From: Miroslav Benes > > > > Currently, livepatch infrastructure in the kernel relies on > > MODULE_INFO(livepatch, "Y") statement in a livepatch module. Then the > > kernel

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-08-12 Thread Joe Lawrence
On Wed, Jul 31, 2019 at 02:58:27PM +0900, Masahiro Yamada wrote: > Hi Joe, > > > On Thu, May 9, 2019 at 11:39 PM Joe Lawrence wrote: > > > > From: Miroslav Benes > > > > Currently, livepatch infrastructure in the kernel relies on > > MODULE_INFO(livepatch, "Y") statement in a livepatch module.

Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-07-30 Thread Masahiro Yamada
Hi Joe, On Thu, May 9, 2019 at 11:39 PM Joe Lawrence wrote: > > From: Miroslav Benes > > Currently, livepatch infrastructure in the kernel relies on > MODULE_INFO(livepatch, "Y") statement in a livepatch module. Then the > kernel module loader knows a module is indeed livepatch module and can

[PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-05-09 Thread Joe Lawrence
From: Miroslav Benes Currently, livepatch infrastructure in the kernel relies on MODULE_INFO(livepatch, "Y") statement in a livepatch module. Then the kernel module loader knows a module is indeed livepatch module and can behave accordingly. klp-convert, on the other hand relies on LIVEPATCH_*