Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-29 Thread Shuo A Liu
On Mon 28.Sep'20 at 14:26:02 +0200, Greg Kroah-Hartman wrote: On Mon, Sep 28, 2020 at 02:29:34PM +0800, Shuo A Liu wrote: On Mon 28.Sep'20 at 7:25:16 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 28, 2020 at 11:50:30AM +0800, Shuo A Liu wrote: > > > > + write_lock_bh(&acrn_vm_list_lock); > >

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-28 Thread Greg Kroah-Hartman
On Mon, Sep 28, 2020 at 02:29:34PM +0800, Shuo A Liu wrote: > On Mon 28.Sep'20 at 7:25:16 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 28, 2020 at 11:50:30AM +0800, Shuo A Liu wrote: > > > > > + write_lock_bh(&acrn_vm_list_lock); > > > > > + list_add(&vm->list, &acrn_vm_list); > > > >

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-28 Thread Shuo A Liu
Hi Greg, On Sun 27.Sep'20 at 12:45:38 +0200, Greg Kroah-Hartman wrote: On Tue, Sep 22, 2020 at 07:43:00PM +0800, shuo.a@intel.com wrote: From: Shuo Liu The VM management interfaces expose several VM operations to ACRN userspace via ioctls. For example, creating VM, starting VM, destroying

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-28 Thread Shuo A Liu
Hi Greg, On Sun 27.Sep'20 at 12:47:02 +0200, Greg Kroah-Hartman wrote: On Tue, Sep 22, 2020 at 07:43:00PM +0800, shuo.a@intel.com wrote: From: Shuo Liu The VM management interfaces expose several VM operations to ACRN userspace via ioctls. For example, creating VM, starting VM, destroying

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-27 Thread Shuo A Liu
On Mon 28.Sep'20 at 7:25:16 +0200, Greg Kroah-Hartman wrote: On Mon, Sep 28, 2020 at 11:50:30AM +0800, Shuo A Liu wrote: > > + write_lock_bh(&acrn_vm_list_lock); > > + list_add(&vm->list, &acrn_vm_list); > > + write_unlock_bh(&acrn_vm_list_lock); > > Why are the _bh() variants being

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-27 Thread Greg Kroah-Hartman
On Mon, Sep 28, 2020 at 11:50:30AM +0800, Shuo A Liu wrote: > > > + write_lock_bh(&acrn_vm_list_lock); > > > + list_add(&vm->list, &acrn_vm_list); > > > + write_unlock_bh(&acrn_vm_list_lock); > > > > Why are the _bh() variants being used here? > > > > You are only accessing this list from userspa

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-27 Thread Greg Kroah-Hartman
On Tue, Sep 22, 2020 at 07:43:00PM +0800, shuo.a@intel.com wrote: > From: Shuo Liu > > The VM management interfaces expose several VM operations to ACRN > userspace via ioctls. For example, creating VM, starting VM, destroying > VM and so on. > > The ACRN Hypervisor needs to exchange data wi

Re: [PATCH v4 06/17] virt: acrn: Introduce VM management interfaces

2020-09-27 Thread Greg Kroah-Hartman
On Tue, Sep 22, 2020 at 07:43:00PM +0800, shuo.a@intel.com wrote: > From: Shuo Liu > > The VM management interfaces expose several VM operations to ACRN > userspace via ioctls. For example, creating VM, starting VM, destroying > VM and so on. > > The ACRN Hypervisor needs to exchange data wi